Skip to content

Commit 974e0d1

Browse files
test: retire the outputs no longer bigger than swc's or oxc's
Three outputs no longer trail swc and two no longer trail oxc. Six test262 getters are 13 to 17 bytes shorter but gzip 4 to 10 bytes worse, as the kept getter is called where terser repeats its string.
1 parent 6a26b75 commit 974e0d1

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

‎test/helpers/oxcSmaller.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -607,11 +607,9 @@ const OXC_SMALLER_BY_REASON = [
607607
"swc minifier: benches-full/jquery.js",
608608
"swc minifier: benches-full/three.js",
609609
"swc minifier: benches-full/vue.js",
610-
"swc minifier: fixture/issues/5682/input.js",
611610
"swc minifier: fixture/issues/d3-color/1/input.js",
612611
"swc minifier: fixture/issues/firebase/dist/1/input.js",
613612
"swc minifier: fixture/issues/react/hooks/3/input.js",
614-
"swc minifier: fixture/issues/react-instancesearch/004/input.js",
615613
"swc minifier: fixture/next/36127/2/3/input.js",
616614
"swc minifier: fixture/next/41527/1/input.js",
617615
"swc minifier: fixture/next/47005/input.js",

‎test/helpers/swcSmaller.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ const SWC_SMALLER_BY_REASON = [
257257
"terser compress: reduce_vars/defun_inline_2",
258258
"terser compress: reduce_vars/issue_1606",
259259
"terser compress: reduce_vars/issue_1850_4",
260-
"terser compress: reduce_vars/issue_294",
261260
"terser compress: reduce_vars/issue_3110_3",
262261
"terser compress: reduce_vars/regex_loop",
263262
"terser compress: reduce_vars/unsafe_evaluate_array_1",
@@ -345,8 +344,7 @@ const SWC_SMALLER_BY_REASON = [
345344
"terser compress: identity/inline_identity_higher_order",
346345
"terser compress: inline/issue_308",
347346
"terser compress: issue-t292/no_flatten_with_arg_colliding_with_arg_value_inner_scope",
348-
"terser compress: issue-t292/no_flatten_with_var_colliding_with_arg_value_inner_scope",
349-
"terser compress: reduce_vars/variables_collision_in_immediately_invoked_func"
347+
"terser compress: issue-t292/no_flatten_with_var_colliding_with_arg_value_inner_scope"
350348
]
351349
],
352350
[
@@ -682,7 +680,6 @@ const SWC_SMALLER_BY_REASON = [
682680
"swc minifier: fixture/next/66237/input.js",
683681
"swc minifier: fixture/next/66378/input.js",
684682
"swc minifier: fixture/next/brotli-decompress/static/chunks/545-ff8f898b276d138f/input.js",
685-
"swc minifier: fixture/next/chakra/input.js",
686683
"swc minifier: fixture/next/cryptojs/input.js",
687684
"swc minifier: fixture/next/feedback-3/579-dcac359116b2707c/input.js",
688685
"swc minifier: fixture/next/octokit/static/chunks/357-72bd409f1472b1b8/input.js",

‎test/specCases/minify-corpora.spectest.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1444,6 +1444,18 @@ const IMPROVED_YET_BIGGER = {
14441444
"11 to 14 bytes fewer, 2 to 3 more gzipped: each folded call repeats the string the test asserts it equals",
14451445
"return-values.js (the default minimizer's options)":
14461446
"392 bytes fewer, 18 more gzipped: each folded call repeats the string the test asserts it equals",
1447+
"15.2.3.6-4-314.js (the default minimizer's options)":
1448+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
1449+
"15.2.3.6-4-314-1.js (the default minimizer's options)":
1450+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
1451+
"15.2.3.6-4-315.js (the default minimizer's options)":
1452+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
1453+
"15.2.3.6-4-315-1.js (the default minimizer's options)":
1454+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
1455+
"15.2.3.6-4-321.js (the default minimizer's options)":
1456+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
1457+
"15.2.3.6-4-321-1.js (the default minimizer's options)":
1458+
"13 to 17 bytes fewer, 4 to 10 more gzipped: the getter kept for `get` is called where terser repeats the string it returns, which gzip reused",
14471459
};
14481460

14491461
// Sources whose shorter spelling no longer repeats text gzip matched, by the

0 commit comments

Comments
 (0)