Repository navigation
Commit 8a404c6
authored
fix(DefinePlugin): destructure a dotted key of any value shape (#22215)
* fix(DefinePlugin): destructure a dotted key of any value shape
Reading `const { X } = process.env` substituted a dotted define only when
its value was a truthy primitive. Two guards read the value where they
meant to ask its shape: the merged view skipped anything `typeof
"object"`, which a RuntimeValue and a RegExp are, and anything falsy; the
destructuring handler then re-tested the value for truthiness. One
unusable id abandons the whole destructuring, so a single `0` among the
defines silently disabled substitution for its siblings too.
An empty string stays out: it renders to no code, which the member path
tolerates and an object literal cannot hold.
* chore: keep the new comment within two lines1 parent a09da3b commit 8a404c6
4 files changed
Lines changed: 67 additions & 2 deletions
File tree
- .changeset
- lib
- test/configCases/plugins/define-plugin-destructure-dotted
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
613 | | - | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
614 | 616 | | |
615 | 617 | | |
616 | 618 | | |
| |||
1261 | 1263 | | |
1262 | 1264 | | |
1263 | 1265 | | |
1264 | | - | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
1265 | 1270 | | |
1266 | 1271 | | |
1267 | 1272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
0 commit comments