fix: improve CLI number validation and add regression tests (#20697)

phoekerson · web-flow · commit 7bde8ab8d018 · 2026-03-25T20:51:05.000+03:00
diff --git a/lib/cli.js b/lib/cli.js
@@ -603,6 +603,8 @@ const getExpectedValue = (argConfig) => {
 
 /** @typedef {null | string | number | boolean | RegExp | EnumValue | []} ParsedValue */
 
+const DECIMAL_NUMBER_REGEXP = /^[+-]?(?:\d+\.?\d*|\.\d+)(?:e[+-]?\d+)?$/i;
+
 /**
  * @param {ArgumentConfig} argConfig processing instructions
  * @param {Value} value the value
@@ -622,7 +624,7 @@ const parseValueForArgumentConfig = (argConfig, value) => {
 			break;
 		case "number":
 			if (typeof value === "number") return value;
-			if (typeof value === "string" && /^[+-]?\d*(\.\d*)e\d+$/i) {
+			if (typeof value === "string" && DECIMAL_NUMBER_REGEXP.test(value)) {
 				const n = Number(value);
 				if (!Number.isNaN(n)) return n;
 			}
diff --git a/test/Cli.basictest.js b/test/Cli.basictest.js
@@ -279,6 +279,108 @@ describe("Cli", () => {
 		`)
 		);
 
+		test(
+			"numbers decimal and scientific notation strings",
+			{
+				"watch-options-aggregate-timeout": ".25",
+				"watch-options-poll": "1e2",
+				"output-chunk-load-timeout": "5.",
+				parallelism: "1e+2",
+				"performance-max-asset-size": "1.5e3",
+				"performance-max-entrypoint-size": "2e-1",
+				"stats-assets-space": "10E+1",
+				"stats-errors-space": "+.5"
+			},
+			{},
+			(e) =>
+				e.toMatchInlineSnapshot(`
+			Object {
+			  "output": Object {
+			    "chunkLoadTimeout": 5,
+			  },
+			  "parallelism": 100,
+			  "performance": Object {
+			    "maxAssetSize": 1500,
+			    "maxEntrypointSize": 0.2,
+			  },
+			  "stats": Object {
+			    "assetsSpace": 100,
+			    "errorsSpace": 0.5,
+			  },
+			  "watchOptions": Object {
+			    "aggregateTimeout": 0.25,
+			    "poll": 100,
+			  },
+			}
+		`)
+		);
+
+		test(
+			"invalid number strings (decimal and exponent edge cases)",
+			{
+				parallelism: "1e",
+				"performance-max-asset-size": "e10",
+				"performance-max-entrypoint-size": "1e2.5",
+				"stats-assets-space": "1.2.3",
+				"output-chunk-load-timeout": "7e-",
+				"stats-warnings-space": "++1"
+			},
+			{},
+			(e) =>
+				e.toMatchInlineSnapshot(`
+			Array [
+			  Object {
+			    "argument": "parallelism",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "parallelism",
+			    "type": "invalid-value",
+			    "value": "1e",
+			  },
+			  Object {
+			    "argument": "performance-max-asset-size",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "performance.maxAssetSize",
+			    "type": "invalid-value",
+			    "value": "e10",
+			  },
+			  Object {
+			    "argument": "performance-max-entrypoint-size",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "performance.maxEntrypointSize",
+			    "type": "invalid-value",
+			    "value": "1e2.5",
+			  },
+			  Object {
+			    "argument": "stats-assets-space",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "stats.assetsSpace",
+			    "type": "invalid-value",
+			    "value": "1.2.3",
+			  },
+			  Object {
+			    "argument": "output-chunk-load-timeout",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "output.chunkLoadTimeout",
+			    "type": "invalid-value",
+			    "value": "7e-",
+			  },
+			  Object {
+			    "argument": "stats-warnings-space",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "stats.warningsSpace",
+			    "type": "invalid-value",
+			    "value": "++1",
+			  },
+			]
+		`)
+		);
+
 		test(
 			"booleans and enums",
 			{
@@ -323,6 +425,8 @@ describe("Cli", () => {
 				"output-library-name": "non-object",
 				"resolve-loader-unsafe-cache": [true, false],
 				"output-chunk-load-timeout": "20000x",
+				"watch-options-aggregate-timeout": "Infinity",
+				"watch-options-poll": "0x10",
 				"cache-type": "filsystem",
 				"entry-reset": false,
 				"module-unknown-context-reg-exp": "ab?c*",
@@ -366,6 +470,30 @@ describe("Cli", () => {
 			    "type": "invalid-value",
 			    "value": "20000x",
 			  },
+			  Object {
+			    "argument": "watch-options-aggregate-timeout",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "watchOptions.aggregateTimeout",
+			    "type": "invalid-value",
+			    "value": "Infinity",
+			  },
+			  Object {
+			    "argument": "watch-options-poll",
+			    "expected": "number",
+			    "index": undefined,
+			    "path": "watchOptions.poll",
+			    "type": "invalid-value",
+			    "value": "0x10",
+			  },
+			  Object {
+			    "argument": "watch-options-poll",
+			    "expected": "true | false",
+			    "index": undefined,
+			    "path": "watchOptions.poll",
+			    "type": "invalid-value",
+			    "value": "0x10",
+			  },
 			  Object {
 			    "argument": "cache-type",
 			    "expected": "memory",
