lib: change handling for mjs import to use namespace

y-okt · y-okt · commit 76c88e4b7ae2 · 2025-12-16T07:19:50.000+09:00
remove module federation implementation to separately do so in another MR Fixes: #20189
diff --git a/lib/sharing/ConsumeSharedModule.js b/lib/sharing/ConsumeSharedModule.js
@@ -165,9 +165,30 @@ class ConsumeSharedModule extends Module {
 	 * "default-with-named": Provide a namespace object with named and default export. namespace = { ...exports, default: exports }
 	 */
 	getExportsType(moduleGraph, strict) {
-		if (this.buildMeta && this.buildMeta.exportsType === "namespace") {
-			return "namespace";
+		if (this.options.import) {
+			let fallbackModule = null;
+
+			if (this.options.eager) {
+				const dep = this.dependencies[0];
+				if (dep) {
+					fallbackModule = moduleGraph.getModule(dep);
+				}
+			} else {
+				const block = this.blocks[0];
+				if (block && block.dependencies.length > 0) {
+					fallbackModule = moduleGraph.getModule(block.dependencies[0]);
+				}
+			}
+
+			if (
+				fallbackModule &&
+				fallbackModule.buildMeta &&
+				fallbackModule.buildMeta.exportsType === "namespace"
+			) {
+				return "namespace";
+			}
 		}
+
 		return "dynamic";
 	}
 
diff --git a/lib/sharing/ConsumeSharedPlugin.js b/lib/sharing/ConsumeSharedPlugin.js
@@ -371,47 +371,6 @@ class ConsumeSharedPlugin {
 						);
 					}
 				);
-
-				compilation.hooks.finishModules.tapAsync(
-					{ name: PLUGIN_NAME, stage: 10 },
-					(modules, callback) => {
-						for (const module of modules) {
-							if (
-								!(module instanceof ConsumeSharedModule) ||
-								!module.options.import
-							) {
-								continue;
-							}
-
-							let dependency;
-							if (module.options.eager) {
-								dependency = module.dependencies[0];
-							} else {
-								const block = module.blocks[0];
-								if (block) {
-									dependency = block.dependencies[0];
-								}
-							}
-
-							if (dependency) {
-								const fallbackModule =
-									compilation.moduleGraph.getModule(dependency);
-								if (
-									fallbackModule &&
-									fallbackModule.buildMeta &&
-									fallbackModule.buildInfo
-								) {
-									module.buildMeta = { ...fallbackModule.buildMeta };
-									module.buildInfo = { ...fallbackModule.buildInfo };
-									compilation.moduleGraph
-										.getExportsInfo(module)
-										.setUnknownExportsProvided();
-								}
-							}
-						}
-						callback();
-					}
-				);
 			}
 		);
 	}
