refactor: use variable declaration for inactive harmony imports instead of inline undefined

samarthsinh2660 · samarthsinh2660 · commit 75e3c825b409 · 2026-01-06T10:22:03.000+05:30
diff --git a/lib/dependencies/HarmonyImportSpecifierDependency.js b/lib/dependencies/HarmonyImportSpecifierDependency.js
@@ -6,6 +6,7 @@
 "use strict";
 
 const Dependency = require("../Dependency");
+const InitFragment = require("../InitFragment");
 const Template = require("../Template");
 const {
 	getDependencyUsedByExportsCondition
@@ -342,18 +343,17 @@ HarmonyImportSpecifierDependency.Template = class HarmonyImportSpecifierDependen
 
 		// Skip rendering depending when dependency is conditional
 		if (connection && !connection.isTargetActive(runtime)) {
-			const {
-				trimmedRange: [trimmedRangeStart, trimmedRangeEnd]
-			} = getTrimmedIdsAndRange(ids, dep.range, dep.idRanges, moduleGraph, dep);
 			const comment = Template.toNormalComment(
 				`inactive harmony import ${dep.name} ${ids.join(".")}`
 			);
-			const expr = `${comment} undefined`;
-			if (dep.shorthand) {
-				source.insert(trimmedRangeEnd, `: ${expr}`);
-			} else {
-				source.replace(trimmedRangeStart, trimmedRangeEnd - 1, expr);
-			}
+			templateContext.initFragments.push(
+				new InitFragment(
+					`var ${dep.name} = ${comment} undefined;\n`,
+					InitFragment.STAGE_HARMONY_IMPORTS,
+					0,
+					`inactive harmony import ${dep.name}`
+				)
+			);
 			return;
 		}
 		const {
diff --git a/test/configCases/issues/issue-20151/index.js b/test/configCases/issues/issue-20151/index.js
@@ -10,5 +10,13 @@ it("should correctly handle unused function with same-named local variable", ()
 	expect(__).toBe("local");
 });
 
+it("should declare inactive harmony imports as variables", () => {
+	const fs = require("fs");
+	const source = fs.readFileSync(__filename, "utf-8");
+	// The identifier should remain in the code, but be declared as undefined
+	expect(source).toContain("var i18n = /* inactive harmony import i18n __ */ undefined;");
+	expect(source).toMatch(/return i18n\("wtf"\)/);
+});
+
 // This ensures unused is not tree-shaken in some configurations
 export { unused };
