Repository navigation
Commit 6b1beda
fix(css): write an opaque wide-gamut fallback without an alpha, and keep a mix's own hue method
Three findings from the review, two of them colors an engine reads differently:
- `_wideGamutColor` was the third caller of `_alphaByteText` and the one still
passing it `255`: an alpha above 254.5/255 quantizes to the opaque byte, and
the helper answers `.` for it, so `color(display-p3 … / .)` reached a target
that reads `color()` but no Lab family. The alpha is quantized before it is
written now, and an opaque one is left off.
- `_foldColorMix` held the hue interpolation method in module state across the
two `_resolveColor` calls, and a nested `color-mix()` folds through the same
function — so the inner method decided the outer mix. It is held locally
until both colors resolve.
- the mark `unusedSymbols` leaves on a rule is now read whichever reason drops
an empty rule, rather than after a `||` that a qualified rule short-circuits:
an unread mark rides the node back into the pool, which is the hazard
`_takeUnusedRule` documents.
The two changesets this pull request added are one, as the guide asks.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_018tNx7sU4SbnKFhFeofDVr51 parent a32e693 commit 6b1beda
4 files changed
Lines changed: 38 additions & 13 deletions
File tree
- .changeset
- lib/css
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4953 | 4953 | | |
4954 | 4954 | | |
4955 | 4955 | | |
4956 | | - | |
| 4956 | + | |
| 4957 | + | |
| 4958 | + | |
| 4959 | + | |
4957 | 4960 | | |
4958 | 4961 | | |
4959 | | - | |
4960 | | - | |
| 4962 | + | |
4961 | 4963 | | |
4962 | 4964 | | |
4963 | 4965 | | |
| |||
8395 | 8397 | | |
8396 | 8398 | | |
8397 | 8399 | | |
8398 | | - | |
| 8400 | + | |
| 8401 | + | |
| 8402 | + | |
| 8403 | + | |
8399 | 8404 | | |
8400 | 8405 | | |
8401 | 8406 | | |
| |||
8736 | 8741 | | |
8737 | 8742 | | |
8738 | 8743 | | |
8739 | | - | |
8740 | | - | |
| 8744 | + | |
| 8745 | + | |
| 8746 | + | |
| 8747 | + | |
8741 | 8748 | | |
8742 | 8749 | | |
8743 | | - | |
| 8750 | + | |
8744 | 8751 | | |
8745 | 8752 | | |
8746 | 8753 | | |
| |||
8782 | 8789 | | |
8783 | 8790 | | |
8784 | 8791 | | |
| 8792 | + | |
8785 | 8793 | | |
8786 | 8794 | | |
8787 | 8795 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7909 | 7909 | | |
7910 | 7910 | | |
7911 | 7911 | | |
| 7912 | + | |
| 7913 | + | |
| 7914 | + | |
| 7915 | + | |
| 7916 | + | |
| 7917 | + | |
| 7918 | + | |
| 7919 | + | |
7912 | 7920 | | |
7913 | 7921 | | |
7914 | 7922 | | |
| |||
8026 | 8034 | | |
8027 | 8035 | | |
8028 | 8036 | | |
| 8037 | + | |
| 8038 | + | |
| 8039 | + | |
| 8040 | + | |
| 8041 | + | |
| 8042 | + | |
| 8043 | + | |
| 8044 | + | |
| 8045 | + | |
| 8046 | + | |
| 8047 | + | |
| 8048 | + | |
| 8049 | + | |
| 8050 | + | |
8029 | 8051 | | |
8030 | 8052 | | |
8031 | 8053 | | |
| |||
0 commit comments