Repository navigation
Commit 5f281e9
committed
fix(javascript): find an HTML comment's line by scanning, not by pattern
A pattern spelling `<!--` and `-->` reads as a filter over HTML, which
CodeQL reports as an incomplete one; this decides which parser reads a
source, and filters nothing. A scan says the same thing without a pattern,
and skips the line it would have walked where neither spelling occurs.
Also say in docs/syntax.md what the printer's `parse` phase now does, and
what `parse.webpackParser` turns off.1 parent 755942b commit 5f281e9
2 files changed
Lines changed: 32 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16506 | 16506 | | |
16507 | 16507 | | |
16508 | 16508 | | |
16509 | | - | |
16510 | | - | |
| 16509 | + | |
| 16510 | + | |
| 16511 | + | |
| 16512 | + | |
| 16513 | + | |
| 16514 | + | |
| 16515 | + | |
| 16516 | + | |
| 16517 | + | |
| 16518 | + | |
| 16519 | + | |
| 16520 | + | |
| 16521 | + | |
| 16522 | + | |
| 16523 | + | |
| 16524 | + | |
| 16525 | + | |
| 16526 | + | |
| 16527 | + | |
| 16528 | + | |
| 16529 | + | |
| 16530 | + | |
| 16531 | + | |
| 16532 | + | |
| 16533 | + | |
| 16534 | + | |
| 16535 | + | |
| 16536 | + | |
| 16537 | + | |
| 16538 | + | |
16511 | 16539 | | |
16512 | 16540 | | |
16513 | 16541 | | |
| |||
16897 | 16925 | | |
16898 | 16926 | | |
16899 | 16927 | | |
16900 | | - | |
| 16928 | + | |
16901 | 16929 | | |
16902 | 16930 | | |
16903 | 16931 | | |
| |||
0 commit comments