Repository navigation
Commit 5e6c4d7
authored
fix(defer): evaluate async dependencies where the deferred import sits (#21902)
* fix(defer): evaluate async dependencies where the deferred import sits
A deferred import's async transitive dependencies were only started when
the importing module awaited its dependencies, so every synchronous
sibling ran first. They now start at the import, as the spec's
`GatherAsynchronousTransitiveDependencies` requires, skipping a module
that is already evaluating so a cycle back to the importer cannot
deadlock. Gathering them walks the imports in source order, which the
outgoing-connections map did not preserve under production ids.
Un-skips test262's import-defer flattening-order case.
* perf(defer): gather the started async dependencies with a filter
* fix(defer): propagate a rejected async dependency to every importer
A rejected async module still sets its done flag, so a later deferred
import of the same subgraph read it as finished and never awaited it,
dropping the error. It is now awaited whenever it carries one.
The old check read the flag from the module record, where it is never
set, so it meant "not yet required" and hid this behind the first
importer; rewriting it for the evaluation-order fix made it reachable
from the predicate itself.
* docs: keep the async-dependency comment to two lines1 parent 7ea4fa3 commit 5e6c4d7
17 files changed
Lines changed: 89 additions & 8 deletions
File tree
- .changeset
- lib
- async-modules
- runtime
- test
- configCases/defer-import
- async-dependency-rejection
- async-transitive-evaluation-order
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
36 | 42 | | |
| 43 | + | |
37 | 44 | | |
38 | 45 | | |
39 | 46 | | |
40 | 47 | | |
41 | | - | |
42 | | - | |
| 48 | + | |
43 | 49 | | |
44 | | - | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
61 | 65 | | |
62 | 66 | | |
63 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
290 | 290 | | |
291 | 291 | | |
292 | 292 | | |
293 | | - | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
294 | 304 | | |
295 | 305 | | |
296 | 306 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
0 commit comments