Repository navigation
Commit 37f87b9
fix(css): drop no declaration a keyframe, a revert or a slot's arity keeps
The browser tier over web-platform-tests caught three colors and animations this
turn's own redundancy removal changed the meaning of.
- CSS Animations 1 §3 ignores an `!important` declaration inside a keyframe, so
the plain one before it is what the engine reads. `border-color:green;
border-color:red!important` kept only the important one, which the engine then
discards — the element lost its border color rather than gaining a red one
(`css-cascade/important-prop.html`).
- The rule-level override read the later block's *first* declaration of the
property rather than its last, so `#t{color:green}` before
`#t{color:red;color:revert-rule}` was compared against the red and dropped.
`revert-rule` reads back to that very rule, so the color went green to red
(`css-cascade/revert-rule-layer.html`). The last one decides now, which is
also what leaves the `revert` family declining on its own terms.
- One slot takes the iteration count and two take a time, so `animation:1 2`,
`animation:1 1`, `animation:0s 0s 0s` and `transition:0s 0s 0s` are layers no
engine reads — and dropping the default from one handed back a layer that
runs. Both droppers decline where a layer names more than the slots take.
The folds that were right stay: `animation:0s 0s` is still `animation:0s`,
`animation:x 1 2s` still loses its count, and an `!important` outside a keyframe
still stands over what precedes it.
The two changesets this pull request carried are one, as the guide asks, and the
`};` recovery case in the html suite names two properties now — with one, the
override removal takes the pair it was written to show.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_018tNx7sU4SbnKFhFeofDVr51 parent 7c5c6d9 commit 37f87b9
5 files changed
Lines changed: 70 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11917 | 11917 | | |
11918 | 11918 | | |
11919 | 11919 | | |
| 11920 | + | |
| 11921 | + | |
| 11922 | + | |
| 11923 | + | |
| 11924 | + | |
| 11925 | + | |
| 11926 | + | |
11920 | 11927 | | |
11921 | 11928 | | |
11922 | 11929 | | |
| |||
11940 | 11947 | | |
11941 | 11948 | | |
11942 | 11949 | | |
| 11950 | + | |
| 11951 | + | |
| 11952 | + | |
| 11953 | + | |
| 11954 | + | |
| 11955 | + | |
| 11956 | + | |
| 11957 | + | |
11943 | 11958 | | |
11944 | 11959 | | |
11945 | 11960 | | |
| |||
13296 | 13311 | | |
13297 | 13312 | | |
13298 | 13313 | | |
13299 | | - | |
13300 | | - | |
13301 | | - | |
13302 | | - | |
13303 | | - | |
13304 | | - | |
| 13314 | + | |
| 13315 | + | |
| 13316 | + | |
| 13317 | + | |
| 13318 | + | |
| 13319 | + | |
| 13320 | + | |
| 13321 | + | |
| 13322 | + | |
13305 | 13323 | | |
13306 | 13324 | | |
13307 | 13325 | | |
| |||
14251 | 14269 | | |
14252 | 14270 | | |
14253 | 14271 | | |
| 14272 | + | |
| 14273 | + | |
| 14274 | + | |
| 14275 | + | |
| 14276 | + | |
| 14277 | + | |
| 14278 | + | |
14254 | 14279 | | |
14255 | 14280 | | |
14256 | 14281 | | |
| |||
14297 | 14322 | | |
14298 | 14323 | | |
14299 | 14324 | | |
14300 | | - | |
| 14325 | + | |
| 14326 | + | |
| 14327 | + | |
14301 | 14328 | | |
14302 | 14329 | | |
14303 | 14330 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5915 | 5915 | | |
5916 | 5916 | | |
5917 | 5917 | | |
| 5918 | + | |
| 5919 | + | |
| 5920 | + | |
| 5921 | + | |
| 5922 | + | |
| 5923 | + | |
| 5924 | + | |
| 5925 | + | |
| 5926 | + | |
| 5927 | + | |
| 5928 | + | |
| 5929 | + | |
5918 | 5930 | | |
5919 | 5931 | | |
5920 | 5932 | | |
| |||
5951 | 5963 | | |
5952 | 5964 | | |
5953 | 5965 | | |
5954 | | - | |
| 5966 | + | |
| 5967 | + | |
| 5968 | + | |
| 5969 | + | |
| 5970 | + | |
| 5971 | + | |
| 5972 | + | |
5955 | 5973 | | |
5956 | 5974 | | |
5957 | 5975 | | |
5958 | 5976 | | |
| 5977 | + | |
| 5978 | + | |
| 5979 | + | |
| 5980 | + | |
| 5981 | + | |
| 5982 | + | |
| 5983 | + | |
| 5984 | + | |
| 5985 | + | |
| 5986 | + | |
| 5987 | + | |
| 5988 | + | |
| 5989 | + | |
5959 | 5990 | | |
5960 | 5991 | | |
5961 | 5992 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5263 | 5263 | | |
5264 | 5264 | | |
5265 | 5265 | | |
5266 | | - | |
5267 | | - | |
5268 | | - | |
| 5266 | + | |
| 5267 | + | |
| 5268 | + | |
5269 | 5269 | | |
5270 | 5270 | | |
5271 | 5271 | | |
| |||
0 commit comments