You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3618e21
Browse filesBrowse the repository at this point in the historyBrowse files
fix: keep sibling entry connections when re-factorizing a shared entry module
The null-origin seed cleanup is meant for freshly minted seeding
dependencies (prefetch chains); a re-factorize reuses a persisted entry
dependency, so the cleanup dropped other entries pointing at the same
module.
Copy file name to clipboardExpand all lines: lib/Compilation.js
+9-4Lines changed: 9 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -2510,6 +2510,7 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
2510
2510
* @property {boolean=} recursive recurse into dependencies of the created module
2511
2511
* @property {boolean=} connectOrigin connect the resolved module with the origin module
2512
2512
* @property {boolean=} checkCycle check the cycle dependencies of the created module
2513
+
* @property {boolean=} reusedDependencies dependencies are persisted from the previous compilation (incremental re-factorize), not freshly minted seeds
2513
2514
*/
2514
2515
2515
2516
/**
@@ -2527,7 +2528,8 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
2527
2528
context,
2528
2529
recursive =true,
2529
2530
connectOrigin =recursive,
2530
-
checkCycle =!recursive
2531
+
checkCycle =!recursive,
2532
+
reusedDependencies =false
2531
2533
},
2532
2534
callback
2533
2535
){
@@ -2643,8 +2645,10 @@ BREAKING CHANGE: Asset processing hooks in Compilation has been merged into a si
2643
2645
moduleGraph.setIssuer(module,null);
2644
2646
this._incrementalSeedRoots.add(module);
2645
2647
// a fresh seeding dependency is minted each make (prefetch chains) —
2646
-
// drop the previous makes' connections or they accumulate unbounded
2647
-
if(dependencies.length>0){
2648
+
// drop the previous makes' connections or they accumulate unbounded;
2649
+
// a re-factorize reuses a persisted dependency, where this would
2650
+
// drop sibling entries pointing at the same module
0 commit comments