Repository navigation
Commit 35dad2f
committed
perf(concatenation): release each module's ast after scope analysis
Concatenation and the inlined-entry rename kept every analysed module's
whole ast alive until code generation finished, for one lookup each: is
this identifier the value of a shorthand property?
The analyser now records where each shorthand property's identifier
starts, so the rename reads an offset instead of walking the tree, and
neither caller keeps the ast. A scope kept its opening node too, which
held the tree by itself; it now keeps that node's type and offset.
Over a 1007-module concatenation (three.js + lodash-es, 242k ast nodes),
the GC-stabilized heap at the end of analysis drops from 87.44 MB to
71.06 MB.
getPathInAst had no other caller and is removed with its helpers.1 parent 107ebef commit 35dad2f
13 files changed
Lines changed: 204 additions & 496 deletions
File tree
- .changeset
- lib
- javascript
- optimize
- util
- test
- configCases/concatenate-modules/shorthand-property-collision
- unitCases
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| |||
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | 62 | | |
69 | 63 | | |
70 | 64 | | |
| |||
363 | 357 | | |
364 | 358 | | |
365 | 359 | | |
366 | | - | |
| 360 | + | |
367 | 361 | | |
368 | 362 | | |
369 | 363 | | |
| |||
373 | 367 | | |
374 | 368 | | |
375 | 369 | | |
376 | | - | |
| 370 | + | |
377 | 371 | | |
378 | 372 | | |
379 | 373 | | |
| |||
412 | 406 | | |
413 | 407 | | |
414 | 408 | | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
419 | | - | |
420 | | - | |
421 | | - | |
422 | | - | |
423 | | - | |
424 | | - | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
425 | 412 | | |
426 | 413 | | |
427 | 414 | | |
| |||
2163 | 2150 | | |
2164 | 2151 | | |
2165 | 2152 | | |
2166 | | - | |
| 2153 | + | |
2167 | 2154 | | |
2168 | 2155 | | |
2169 | 2156 | | |
| |||
2296 | 2283 | | |
2297 | 2284 | | |
2298 | 2285 | | |
2299 | | - | |
| 2286 | + | |
2300 | 2287 | | |
2301 | 2288 | | |
2302 | 2289 | | |
| |||
2327 | 2314 | | |
2328 | 2315 | | |
2329 | 2316 | | |
2330 | | - | |
| 2317 | + | |
2331 | 2318 | | |
2332 | 2319 | | |
2333 | 2320 | | |
2334 | 2321 | | |
2335 | 2322 | | |
2336 | 2323 | | |
2337 | | - | |
| 2324 | + | |
2338 | 2325 | | |
2339 | 2326 | | |
2340 | 2327 | | |
| |||
2352 | 2339 | | |
2353 | 2340 | | |
2354 | 2341 | | |
2355 | | - | |
| 2342 | + | |
| 2343 | + | |
| 2344 | + | |
| 2345 | + | |
| 2346 | + | |
2356 | 2347 | | |
2357 | 2348 | | |
2358 | 2349 | | |
| |||
2373 | 2364 | | |
2374 | 2365 | | |
2375 | 2366 | | |
2376 | | - | |
| 2367 | + | |
2377 | 2368 | | |
2378 | 2369 | | |
2379 | 2370 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
119 | | - | |
| 120 | + | |
120 | 121 | | |
121 | 122 | | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
127 | | - | |
128 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
129 | 132 | | |
130 | 133 | | |
131 | 134 | | |
| |||
389 | 392 | | |
390 | 393 | | |
391 | 394 | | |
| 395 | + | |
| 396 | + | |
392 | 397 | | |
393 | 398 | | |
394 | 399 | | |
395 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
396 | 415 | | |
397 | 416 | | |
398 | 417 | | |
| |||
512 | 531 | | |
513 | 532 | | |
514 | 533 | | |
| 534 | + | |
515 | 535 | | |
516 | 536 | | |
517 | 537 | | |
| |||
794 | 814 | | |
795 | 815 | | |
796 | 816 | | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
797 | 822 | | |
798 | 823 | | |
799 | 824 | | |
| |||
1068 | 1093 | | |
1069 | 1094 | | |
1070 | 1095 | | |
| 1096 | + | |
1071 | 1097 | | |
1072 | 1098 | | |
1073 | 1099 | | |
| |||
1084 | 1110 | | |
1085 | 1111 | | |
1086 | 1112 | | |
1087 | | - | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
1088 | 1119 | | |
1089 | 1120 | | |
1090 | 1121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
| |||
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
208 | | - | |
| 207 | + | |
209 | 208 | | |
210 | 209 | | |
211 | 210 | | |
| |||
1710 | 1709 | | |
1711 | 1710 | | |
1712 | 1711 | | |
1713 | | - | |
| 1712 | + | |
1714 | 1713 | | |
1715 | 1714 | | |
1716 | 1715 | | |
| |||
1720 | 1719 | | |
1721 | 1720 | | |
1722 | 1721 | | |
1723 | | - | |
| 1722 | + | |
1724 | 1723 | | |
1725 | 1724 | | |
1726 | 1725 | | |
| |||
2144 | 2143 | | |
2145 | 2144 | | |
2146 | 2145 | | |
| 2146 | + | |
| 2147 | + | |
| 2148 | + | |
2147 | 2149 | | |
2148 | 2150 | | |
2149 | | - | |
2150 | | - | |
2151 | | - | |
2152 | | - | |
2153 | | - | |
2154 | | - | |
2155 | | - | |
2156 | | - | |
2157 | | - | |
2158 | | - | |
2159 | | - | |
2160 | | - | |
2161 | | - | |
2162 | | - | |
2163 | | - | |
2164 | | - | |
2165 | | - | |
2166 | | - | |
| 2151 | + | |
| 2152 | + | |
| 2153 | + | |
2167 | 2154 | | |
2168 | 2155 | | |
2169 | 2156 | | |
| |||
3151 | 3138 | | |
3152 | 3139 | | |
3153 | 3140 | | |
3154 | | - | |
| 3141 | + | |
3155 | 3142 | | |
3156 | 3143 | | |
3157 | 3144 | | |
| |||
3188 | 3175 | | |
3189 | 3176 | | |
3190 | 3177 | | |
3191 | | - | |
| 3178 | + | |
3192 | 3179 | | |
3193 | 3180 | | |
3194 | 3181 | | |
| |||
0 commit comments