Skip to content

Commit 22e1787

Browse files
hai-xhai-x
authored
test: esm runner only link deps when the module is unlinked (#20350)
1 parent 2dde4bb commit 22e1787

6 files changed

Lines changed: 230 additions & 131 deletions

File tree

‎cspell.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,8 @@
318318
"thelarkinn",
319319
"behaviour",
320320
"WHATWG",
321-
"publicpath"
321+
"publicpath",
322+
"Uninstantiated"
322323
],
323324
"ignoreRegExpList": [
324325
"/Author.+/",

‎test/TestCases.template.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const captureStdio = require("./helpers/captureStdio");
1010
const createLazyTestEnv = require("./helpers/createLazyTestEnv");
1111
const deprecationTracking = require("./helpers/deprecationTracking");
1212
const filterInfraStructureErrors = require("./helpers/infrastructureLogErrors");
13-
const { TestRunner } = require("./runner/index");
13+
const { TestRunner } = require("./runner");
1414

1515
const casesPath = path.join(__dirname, "cases");
1616
let categories = fs.readdirSync(casesPath);

‎test/helpers/asModule.js‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎test/runner/RunnerHelpers.js‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
"use strict";
2+
3+
const path = require("path");
4+
5+
/**
6+
* @param {string} path path
7+
* @returns {string} subPath
8+
*/
9+
const getSubPath = (path) => {
10+
let subPath = "";
11+
const lastSlash = path.lastIndexOf("/");
12+
let firstSlash = path.indexOf("/");
13+
if (lastSlash !== -1 && firstSlash !== lastSlash) {
14+
if (firstSlash !== -1) {
15+
let next = path.indexOf("/", firstSlash + 1);
16+
let dir = path.slice(firstSlash + 1, next);
17+
18+
while (dir === ".") {
19+
firstSlash = next;
20+
next = path.indexOf("/", firstSlash + 1);
21+
dir = path.slice(firstSlash + 1, next);
22+
}
23+
}
24+
subPath = path.slice(firstSlash + 1, lastSlash + 1);
25+
}
26+
return subPath;
27+
};
28+
29+
/**
30+
* @param {string} path path
31+
* @returns {boolean} whether path is a relative path
32+
*/
33+
const isRelativePath = (path) => /^\.\.?\//.test(path);
34+
35+
/**
36+
* @param {string} url url
37+
* @param {string} outputDirectory outputDirectory
38+
* @returns {string} absolute path
39+
*/
40+
const urlToPath = (url, outputDirectory) => {
41+
if (url.startsWith("https://test.cases/path/")) url = url.slice(24);
42+
else if (url.startsWith("https://test.cases/")) url = url.slice(19);
43+
return path.resolve(outputDirectory, `./${url}`);
44+
};
45+
46+
/**
47+
* @param {string} url url
48+
* @returns {string} relative path
49+
*/
50+
const urlToRelativePath = (url) => {
51+
if (url.startsWith("https://test.cases/path/")) url = url.slice(24);
52+
else if (url.startsWith("https://test.cases/")) url = url.slice(19);
53+
return `./${url}`;
54+
};
55+
56+
/**
57+
* @returns {number[]} version arr
58+
*/
59+
const getNodeVersion = () => process.versions.node.split(".").map(Number);
60+
61+
const ESModuleStatus = Object.freeze({
62+
Unlinked: "unlinked",
63+
Linked: "linked",
64+
Evaluated: "evaluated",
65+
/**
66+
* Present in `module.linkingStatus`
67+
* Compatible with Node.js v10
68+
* https://nodejs.org/docs/latest-v10.x/api/vm.html#vm_module_status
69+
*/
70+
Uninstantiated: "uninstantiated"
71+
});
72+
73+
module.exports = {
74+
ESModuleStatus,
75+
getNodeVersion,
76+
getSubPath,
77+
isRelativePath,
78+
urlToPath,
79+
urlToRelativePath
80+
};

‎test/runner/asModule.js‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
"use strict";
2+
3+
const vm = require("vm");
4+
const { ESModuleStatus, getNodeVersion } = require("./RunnerHelpers");
5+
6+
const [major] = getNodeVersion();
7+
8+
const SYNTHETIC_MODULES_STORE = "__SYNTHETIC_MODULES_STORE";
9+
const LINKER = () => {};
10+
11+
/**
12+
* @param {vm.SourceTextModule | vm.Module | EXPECTED_ANY} something module or object
13+
* @param {EXPECTED_ANY} context context
14+
* @param {{esmReturnStatus?: boolean}=} options options
15+
* @returns {Promise<vm.SourceTextModule>} module
16+
*/
17+
module.exports = async (something, context, options = {}) => {
18+
if (
19+
something instanceof (vm.Module || /* node.js 10 */ vm.SourceTextModule)
20+
) {
21+
return something;
22+
}
23+
24+
context[SYNTHETIC_MODULES_STORE] = context[SYNTHETIC_MODULES_STORE] || [];
25+
const i = context[SYNTHETIC_MODULES_STORE].length;
26+
context[SYNTHETIC_MODULES_STORE].push(something);
27+
const code = [...new Set(["default", ...Object.keys(something)])]
28+
.map(
29+
(name) =>
30+
`const _${name} = ${SYNTHETIC_MODULES_STORE}[${i}]${
31+
name === "default" ? "" : `[${JSON.stringify(name)}]`
32+
}; export { _${name} as ${name}};`
33+
)
34+
.join("\n");
35+
36+
const esm = new vm.SourceTextModule(code, {
37+
context
38+
});
39+
if (options.esmReturnStatus === ESModuleStatus.Unlinked) return esm;
40+
41+
if (major === 10) {
42+
if (esm.linkingStatus === ESModuleStatus.Unlinked) {
43+
await esm.link(LINKER);
44+
}
45+
if (esm.linkingStatus === ESModuleStatus.Linked) {
46+
esm.instantiate();
47+
}
48+
} else {
49+
await esm.link(LINKER);
50+
}
51+
52+
await esm.evaluate();
53+
return esm;
54+
};

0 commit comments

Comments
 (0)