fix: add a static getSourceBasicTypes to prevent errors across multiple version (#20614)

xiaoxiaojx · web-flow · commit 20eeaeb4e1cb · 2026-03-10T21:07:16.000+03:00
diff --git a/.changeset/add-static-getsourcebasictypes.md b/.changeset/add-static-getsourcebasictypes.md
@@ -0,0 +1,5 @@
+---
+"webpack": patch
+---
+
+Add a static getSourceBasicTypes method to the Module class to prevent errors across multiple versions.
diff --git a/lib/Module.js b/lib/Module.js
@@ -1221,6 +1221,21 @@ class Module extends DependenciesBlock {
 		this.codeGenerationDependencies = read();
 		super.deserialize(context);
 	}
+
+	// TODO remove in webpack 6
+	/**
+	 * @deprecated In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @param {Module} module the module
+	 * @returns {ReturnType<Module["getSourceBasicTypes"]>} the source types of the module
+	 */
+	static getSourceBasicTypes(module) {
+		if (!(module instanceof Module)) {
+			// https://github.com/webpack/webpack/issues/20597
+			// fallback to javascript
+			return JAVASCRIPT_TYPES;
+		}
+		return module.getSourceBasicTypes();
+	}
 }
 
 makeSerializable(Module, "webpack/lib/Module");
diff --git a/lib/dependencies/HarmonyImportSideEffectDependency.js b/lib/dependencies/HarmonyImportSideEffectDependency.js
@@ -5,6 +5,7 @@
 
 "use strict";
 
+const Module = require("../Module");
 const { JAVASCRIPT_TYPE } = require("../ModuleSourceTypeConstants");
 const makeSerializable = require("../util/makeSerializable");
 const HarmonyImportDependency = require("./HarmonyImportDependency");
@@ -13,7 +14,6 @@ const HarmonyImportDependency = require("./HarmonyImportDependency");
 /** @typedef {import("../Dependency")} Dependency */
 /** @typedef {import("../Dependency").GetConditionFn} GetConditionFn */
 /** @typedef {import("../DependencyTemplate").DependencyTemplateContext} DependencyTemplateContext */
-/** @typedef {import("../Module")} Module */
 /** @typedef {import("../ModuleGraph")} ModuleGraph */
 /** @typedef {import("../ModuleGraphConnection").ConnectionState} ConnectionState */
 /** @typedef {import("../javascript/JavascriptParser").ImportAttributes} ImportAttributes */
@@ -76,7 +76,7 @@ HarmonyImportSideEffectDependency.Template = class HarmonyImportSideEffectDepend
 
 		const module = /** @type {Module} */ (moduleGraph.getModule(dependency));
 
-		if (module && !module.getSourceBasicTypes().has(JAVASCRIPT_TYPE)) {
+		if (module && !Module.getSourceBasicTypes(module).has(JAVASCRIPT_TYPE)) {
 			// no need to render import
 			return;
 		}
diff --git a/lib/optimize/ConcatenatedModule.js b/lib/optimize/ConcatenatedModule.js
@@ -1003,7 +1003,9 @@ class ConcatenatedModule extends Module {
 					if (!(connection.dependency instanceof HarmonyImportDependency)) {
 						return false;
 					}
-					if (!connection.module.getSourceBasicTypes().has(JAVASCRIPT_TYPE)) {
+					if (
+						!Module.getSourceBasicTypes(connection.module).has(JAVASCRIPT_TYPE)
+					) {
 						return false;
 					}
 					return (
diff --git a/types.d.ts b/types.d.ts
@@ -3830,6 +3830,12 @@ declare class CssLoadingRuntimeModule extends RuntimeModule {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface CssLoadingRuntimeModulePluginHooks {
 	createStylesheet: SyncWaterfallHook<[string, Chunk], string>;
@@ -5709,6 +5715,12 @@ declare class ExternalModule extends Module {
 	static getExternalModuleNodeCommonjsInitFragment: (
 		runtimeTemplate: RuntimeTemplate
 	) => InitFragment<ChunkRenderContextJavascriptModulesPlugin>;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface ExternalModuleInfo {
 	type: "external";
@@ -6448,6 +6460,12 @@ declare class GetChunkFilenameRuntimeModule extends RuntimeModule {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface GotHandler<T> {
 	(result: T, callback: () => void): void;
@@ -8956,6 +8974,12 @@ declare class JsonpChunkLoadingRuntimeModule extends RuntimeModule {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface JsonpCompilationPluginHooks {
 	linkPreload: SyncWaterfallHook<[string, Chunk], string>;
@@ -9920,6 +9944,12 @@ declare class LoadScriptRuntimeModule extends HelperRuntimeModule {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 
 /**
@@ -10789,6 +10819,12 @@ declare class Module extends DependenciesBlock {
 	get errors(): any;
 	get warnings(): any;
 	used: any;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare class ModuleChunkLoadingRuntimeModule extends RuntimeModule {
 	constructor(runtimeRequirements: ReadonlySet<string>);
@@ -10815,6 +10851,12 @@ declare class ModuleChunkLoadingRuntimeModule extends RuntimeModule {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare class ModuleConcatenationPlugin {
 	constructor();
@@ -11936,6 +11978,12 @@ declare class NormalModule extends Module {
 		compilation: Compilation
 	): NormalModuleCompilationHooks;
 	static deserialize(context: ObjectDeserializerContext): NormalModule;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface NormalModuleCompilationHooks {
 	loader: SyncHook<[AnyLoaderContext, NormalModule]>;
@@ -16610,6 +16658,12 @@ declare class RuntimeModule extends Module {
 	 * Runtime modules which trigger actions on bootstrap
 	 */
 	static STAGE_TRIGGER: number;
+
+	/**
+	 * In webpack 6, call getSourceBasicTypes() directly on the module instance instead of using this static method.
+	 * @deprecated
+	 */
+	static getSourceBasicTypes(module: Module): ReadonlySet<string>;
 }
 declare interface RuntimeRequirementsContext {
 	/**

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"webpack": patch
 +---
++
 +Add a static getSourceBasicTypes method to the Module class to prevent errors across multiple versions.
Original file line number	Diff line number	Diff line change
`@@ -1003,7 +1003,9 @@ class ConcatenatedModule extends Module {`
`1003`	`1003`	`if (!(connection.dependency instanceof HarmonyImportDependency)) {`
`1004`	`1004`	`return false;`
`1005`	`1005`	`}`
`1006`		`- if (!connection.module.getSourceBasicTypes().has(JAVASCRIPT_TYPE)) {`
	`1006`	`+ if (`
	`1007`	`+ !Module.getSourceBasicTypes(connection.module).has(JAVASCRIPT_TYPE)`
	`1008`	`+ ) {`
`1007`	`1009`	`return false;`
`1008`	`1010`	`}`
`1009`	`1011`	`return (`