lib: fix js importing mjs handling

y-okt · y-okt · commit 1badd0fc6617 · 2025-12-16T07:19:50.000+09:00
use namespace rather than dynamic in js importing mjs case Fixes: #20189
diff --git a/lib/sharing/ConsumeSharedModule.js b/lib/sharing/ConsumeSharedModule.js
@@ -165,6 +165,9 @@ class ConsumeSharedModule extends Module {
 	 * "default-with-named": Provide a namespace object with named and default export. namespace = { ...exports, default: exports }
 	 */
 	getExportsType(moduleGraph, strict) {
+		if (this.buildMeta && this.buildMeta.exportsType === "namespace") {
+			return "namespace";
+		}
 		return "dynamic";
 	}
 
diff --git a/lib/sharing/ConsumeSharedPlugin.js b/lib/sharing/ConsumeSharedPlugin.js
@@ -371,6 +371,47 @@ class ConsumeSharedPlugin {
 						);
 					}
 				);
+
+				compilation.hooks.finishModules.tapAsync(
+					{ name: PLUGIN_NAME, stage: 10 },
+					(modules, callback) => {
+						for (const module of modules) {
+							if (
+								!(module instanceof ConsumeSharedModule) ||
+								!module.options.import
+							) {
+								continue;
+							}
+
+							let dependency;
+							if (module.options.eager) {
+								dependency = module.dependencies[0];
+							} else {
+								const block = module.blocks[0];
+								if (block) {
+									dependency = block.dependencies[0];
+								}
+							}
+
+							if (dependency) {
+								const fallbackModule =
+									compilation.moduleGraph.getModule(dependency);
+								if (
+									fallbackModule &&
+									fallbackModule.buildMeta &&
+									fallbackModule.buildInfo
+								) {
+									module.buildMeta = { ...fallbackModule.buildMeta };
+									module.buildInfo = { ...fallbackModule.buildInfo };
+									compilation.moduleGraph
+										.getExportsInfo(module)
+										.setUnknownExportsProvided();
+								}
+							}
+						}
+						callback();
+					}
+				);
 			}
 		);
 	}

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,9 @@ class ConsumeSharedModule extends Module {`
`165`	`165`	`* "default-with-named": Provide a namespace object with named and default export. namespace = { ...exports, default: exports }`
`166`	`166`	`*/`
`167`	`167`	`getExportsType(moduleGraph, strict) {`
	`168`	`+ if (this.buildMeta && this.buildMeta.exportsType === "namespace") {`
	`169`	`+ return "namespace";`
	`170`	`+ }`
`168`	`171`	`return "dynamic";`
`169`	`172`	`}`
`170`	`173`