Skip to content

Commit 1ae8c74

Browse files
committed
test(html): read a token list as the DOM reflects it, not as the prose reads
The set the harness folds a repeat out of was written from the spec calling a list unique, which is a wider line than the printer's: it drops a repeat only where the list reflects as a DOMTokenList, leaving `headers` and `accesskey` as the strings they reflect as. Folding those here hid the difference. The case now carries a repeat in all six lists, where it drove two.
1 parent 35a3353 commit 1ae8c74

4 files changed

Lines changed: 11 additions & 4 deletions

File tree

‎test/configCases/html/attribute-tables/__snapshots__/ConfigCacheTest.snap‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ exports[`ConfigCacheTestCases html attribute-tables attribute-tables should comp
99
</form>
1010
<img src=data:, alt=a decoding=async ismap>
1111
<p draggable=true accesskey=\\"s s\\" itemref=\\"one two\\">draggable</p>
12+
<a href=/x ping=\\"https://example.test/p https://example.test/p https://example.test/q\\">ping</a>
13+
<div itemscope itemtype=https://example.test/T><span itemprop=\\"m n\\">micro</span></div>
14+
<table><tr><th id=h1>h<td headers=\\"h1 h1\\">cell</table>
1215
<video controls autoplay muted playsinline loop></video>
1316
<iframe src=/x allowfullscreen></iframe>
1417
<marquee scrollamount=12 scrolldelay=85>scrolling</marquee>

‎test/configCases/html/attribute-tables/__snapshots__/ConfigTest.snap‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ exports[`ConfigTestCases html attribute-tables attribute-tables should compile 1
99
</form>
1010
<img src=data:, alt=a decoding=async ismap>
1111
<p draggable=true accesskey=\\"s s\\" itemref=\\"one two\\">draggable</p>
12+
<a href=/x ping=\\"https://example.test/p https://example.test/p https://example.test/q\\">ping</a>
13+
<div itemscope itemtype=https://example.test/T><span itemprop=\\"m n\\">micro</span></div>
14+
<table><tr><th id=h1>h<td headers=\\"h1 h1\\">cell</table>
1215
<video controls autoplay muted playsinline loop></video>
1316
<iframe src=/x allowfullscreen></iframe>
1417
<marquee scrollamount=12 scrolldelay=85>scrolling</marquee>

‎test/configCases/html/attribute-tables/page.html‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
</form>
1010
<img src="https://example.test/a.png" alt="a" decoding="ASYNC" ismap="ismap">
1111
<p draggable="TRUE" accesskey=" s s " itemref=" one two one ">draggable</p>
12+
<a href="/x" ping=" https://example.test/p https://example.test/p https://example.test/q ">ping</a>
13+
<div itemscope itemtype=" https://example.test/T https://example.test/T "><span itemprop=" n n m ">micro</span></div>
14+
<table><tr><th id="h1">h</th><td headers=" h1 h1 ">cell</td></tr></table>
1215
<video controls="controls" autoplay="autoplay" muted="muted" playsinline="playsinline" loop="loop"></video>
1316
<iframe src="/x" allowfullscreen="allowfullscreen"></iframe>
1417
<marquee scrollamount=" 012 " scrolldelay=" 085 ">scrolling</marquee>

‎test/helpers/syntaxEquivalence.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,11 +1031,9 @@ const installHelpers = () => {
10311031
"itemtype",
10321032
"ping"
10331033
]);
1034-
// Of those, the ones the spec calls a set of *unique* tokens, where a repeat
1035-
// names nothing the first did not. `ping` is not one: it lists URLs.
1034+
// Of those, the ones the spec reflects as a `DOMTokenList` — a set, so a
1035+
// repeat names nothing — which this engine implements no IDL member for.
10361036
const UNIQUE_TOKEN_LIST_ATTRIBUTES = new Set([
1037-
"accesskey",
1038-
"headers",
10391037
"itemprop",
10401038
"itemref",
10411039
"itemtype"

0 commit comments

Comments
 (0)