test(css): fix lint and address Copilot feedback

claude · claude · commit 1819638e1c05 · 2026-04-27T20:56:17.000Z
- Type the `conventions` array as `ExportsConventionLiteral[]` so TypeScript narrows to the `exportsConvention` enum (fixes the lint job failure on PR #20884). - Convert the second `it()` to use `.then(...).catch(done)` instead of `.then(onFulfilled, done)` — the two-callback form does not forward assertion failures thrown inside the fulfillment callback, so failures could surface as unhandled rejections / timeouts (Copilot review feedback). https://claude.ai/code/session_01Dp4wfcAdJPVdZaBpvD1QNZ
diff --git a/test/configCases/css/named-exports-mangling/index.js b/test/configCases/css/named-exports-mangling/index.js
@@ -72,17 +72,19 @@ it(`should expose the right export shape per convention (${matrixTitle})`, (done
 });
 
 it(`should expose default export when namedExports is disabled (${matrixTitle})`, (done) => {
-	import("./style.module.css?camel-case").then((mod) => {
-		if (namedExports) {
-			// Named exports: the camelCase identifier sits on the namespace
-			expect(mod.btnInfoIsDisabled).toBeDefined();
-		} else {
-			// Default-only mode: exports are nested under `default`
-			expect(mod.default).toBeDefined();
-			expect(mod.default.btnInfoIsDisabled).toBeDefined();
-		}
-		done();
-	}, done);
+	import("./style.module.css?camel-case")
+		.then((mod) => {
+			if (namedExports) {
+				// Named exports: the camelCase identifier sits on the namespace
+				expect(mod.btnInfoIsDisabled).toBeDefined();
+			} else {
+				// Default-only mode: exports are nested under `default`
+				expect(mod.default).toBeDefined();
+				expect(mod.default.btnInfoIsDisabled).toBeDefined();
+			}
+			done();
+		})
+		.catch(done);
 });
 
 it(`should mark JS named exports as mangleable in production for every convention (${matrixTitle})`, () => {
diff --git a/test/configCases/css/named-exports-mangling/webpack.config.js b/test/configCases/css/named-exports-mangling/webpack.config.js
@@ -5,7 +5,10 @@ const webpack = require("../../../../");
 /** @typedef {import("../../../../").Configuration} Configuration */
 /** @typedef {import("../../../../").ParserOptionsByModuleTypeKnown} ParserOptionsByModuleTypeKnown */
 /** @typedef {import("../../../../").GeneratorOptionsByModuleTypeKnown} GeneratorOptionsByModuleTypeKnown */
+/** @typedef {NonNullable<GeneratorOptionsByModuleTypeKnown["css/module"]>["exportsConvention"]} ExportsConvention */
+/** @typedef {Extract<ExportsConvention, string>} ExportsConventionLiteral */
 
+/** @type {ExportsConventionLiteral[]} */
 const conventions = [
 	"as-is",
 	"camel-case",
