Repository navigation
Commit 11a1ebd
authored
feat(minify): close more oxc and swc gaps: quoted keys, unread returns, NaN keys (#22914)
* feat(minify): drop `new` before `RegExp` of a BigInt
`new RegExp(10n)` builds what `RegExp(10n)` does: a BigInt pattern, negated or not, is no regular expression to hand back, so the call is written as for a number. Retires `normalize.rs:221`.
* feat(minify): write computed `NaN` and `null` keys as names
`{[NaN]: 1, [null]: 2}` as `{NaN: 1, null: 2}`, in objects, patterns and classes, where `computed_props` is on; no property mangler renames either name. oxc keeps `[null]`. Retires `convert_computed_props_to_regular_ones`.
* feat(minify): read `a["b"]` as `a.b` when merging branches
Branches spelling a key with and without quotes merge where the run keeps no quote: not under `mangle.properties.keep_quoted: "strict"` or `format.keep_quoted_props`, since plain `keep_quoted` reserves each quoted name everywhere. Retires `minimize_statements.rs:188` and `issue_1674_false_equivalency_of_props`.
* feat(minify): drop the values an unread function called in place returns
Where nothing reads the call, a pure `return` value goes before the body is tightened, so the call unwraps: not of an `async`, named or `arguments`-reading function, nor a value that may read a `let` in its dead zone. Behind `side_effects`. Retires swc `12301`.
* test(minify): build the oxc and swc gaps through webpack
A config case runs each rewrite through a real production build, with and without mangling, keeping quoted keys and with `side_effects` off, checking what each bundle prints and runs. The minimizer runs in the process so the coverage counts.1 parent 9acffe7 commit 11a1ebd
10 files changed
Lines changed: 476 additions & 17 deletions
File tree
- .changeset
- lib/javascript
- test
- configCases/optimization/minify-oxc-syntax-gaps
- helpers
- unitCases/javascript
- __snapshots__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
| |||
9881 | 9882 | | |
9882 | 9883 | | |
9883 | 9884 | | |
| 9885 | + | |
| 9886 | + | |
| 9887 | + | |
| 9888 | + | |
| 9889 | + | |
| 9890 | + | |
| 9891 | + | |
| 9892 | + | |
9884 | 9893 | | |
9885 | 9894 | | |
9886 | 9895 | | |
| |||
26217 | 26226 | | |
26218 | 26227 | | |
26219 | 26228 | | |
| 26229 | + | |
| 26230 | + | |
| 26231 | + | |
| 26232 | + | |
| 26233 | + | |
| 26234 | + | |
| 26235 | + | |
| 26236 | + | |
| 26237 | + | |
| 26238 | + | |
| 26239 | + | |
| 26240 | + | |
| 26241 | + | |
| 26242 | + | |
| 26243 | + | |
| 26244 | + | |
| 26245 | + | |
| 26246 | + | |
| 26247 | + | |
| 26248 | + | |
| 26249 | + | |
| 26250 | + | |
| 26251 | + | |
| 26252 | + | |
| 26253 | + | |
| 26254 | + | |
| 26255 | + | |
| 26256 | + | |
| 26257 | + | |
| 26258 | + | |
| 26259 | + | |
| 26260 | + | |
| 26261 | + | |
| 26262 | + | |
| 26263 | + | |
| 26264 | + | |
| 26265 | + | |
| 26266 | + | |
| 26267 | + | |
| 26268 | + | |
| 26269 | + | |
| 26270 | + | |
| 26271 | + | |
| 26272 | + | |
| 26273 | + | |
| 26274 | + | |
| 26275 | + | |
| 26276 | + | |
| 26277 | + | |
| 26278 | + | |
| 26279 | + | |
| 26280 | + | |
| 26281 | + | |
| 26282 | + | |
| 26283 | + | |
| 26284 | + | |
| 26285 | + | |
| 26286 | + | |
| 26287 | + | |
| 26288 | + | |
| 26289 | + | |
| 26290 | + | |
| 26291 | + | |
| 26292 | + | |
| 26293 | + | |
| 26294 | + | |
| 26295 | + | |
| 26296 | + | |
| 26297 | + | |
| 26298 | + | |
| 26299 | + | |
| 26300 | + | |
| 26301 | + | |
| 26302 | + | |
| 26303 | + | |
| 26304 | + | |
| 26305 | + | |
26220 | 26306 | | |
26221 | 26307 | | |
26222 | 26308 | | |
| |||
29773 | 29859 | | |
29774 | 29860 | | |
29775 | 29861 | | |
29776 | | - | |
29777 | | - | |
| 29862 | + | |
| 29863 | + | |
29778 | 29864 | | |
29779 | 29865 | | |
29780 | 29866 | | |
| |||
29794 | 29880 | | |
29795 | 29881 | | |
29796 | 29882 | | |
| 29883 | + | |
| 29884 | + | |
29797 | 29885 | | |
29798 | 29886 | | |
29799 | 29887 | | |
| |||
35767 | 35855 | | |
35768 | 35856 | | |
35769 | 35857 | | |
| 35858 | + | |
| 35859 | + | |
| 35860 | + | |
| 35861 | + | |
| 35862 | + | |
| 35863 | + | |
| 35864 | + | |
| 35865 | + | |
| 35866 | + | |
| 35867 | + | |
| 35868 | + | |
| 35869 | + | |
| 35870 | + | |
| 35871 | + | |
| 35872 | + | |
| 35873 | + | |
| 35874 | + | |
| 35875 | + | |
| 35876 | + | |
| 35877 | + | |
| 35878 | + | |
| 35879 | + | |
| 35880 | + | |
| 35881 | + | |
35770 | 35882 | | |
35771 | 35883 | | |
35772 | 35884 | | |
35773 | 35885 | | |
35774 | | - | |
| 35886 | + | |
35775 | 35887 | | |
35776 | 35888 | | |
35777 | 35889 | | |
35778 | 35890 | | |
| 35891 | + | |
| 35892 | + | |
| 35893 | + | |
| 35894 | + | |
| 35895 | + | |
| 35896 | + | |
| 35897 | + | |
| 35898 | + | |
| 35899 | + | |
| 35900 | + | |
| 35901 | + | |
| 35902 | + | |
| 35903 | + | |
| 35904 | + | |
| 35905 | + | |
| 35906 | + | |
| 35907 | + | |
| 35908 | + | |
| 35909 | + | |
35779 | 35910 | | |
35780 | 35911 | | |
35781 | 35912 | | |
| |||
35791 | 35922 | | |
35792 | 35923 | | |
35793 | 35924 | | |
35794 | | - | |
| 35925 | + | |
| 35926 | + | |
| 35927 | + | |
35795 | 35928 | | |
35796 | 35929 | | |
35797 | 35930 | | |
| |||
62343 | 62476 | | |
62344 | 62477 | | |
62345 | 62478 | | |
| 62479 | + | |
62346 | 62480 | | |
62347 | 62481 | | |
62348 | 62482 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
0 commit comments