Repository navigation
Conversation
|
|
laymonage
commented
Feb 17, 2026
Comment on lines
+332
to
+334
| createSuccessTestCase("absolutePath #7", { | ||
| testAbsolutePath: "file:///C:/directory/deep/tree", | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it's sufficient for Windows.
Seems OK based on nodejs/node#20080 and https://en.wikipedia.org/wiki/File_URI_scheme#Windows, but I haven't tested it myself
alexander-akait
added a commit
that referenced
this pull request
Sep 8, 2026
* feat: allow `file://` protocol prefix in absolute paths Paths coming from `import.meta.resolve()` are `file://` URLs, so the `absolutePath` keyword accepts an optional `file://` prefix now. Fixes #209 Recreated from #210, rebased on `main`. Co-Authored-By: Sage Abdullah <[email protected]> Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013wqLmVHkAGBsWQgXknEQCK * test: cover every webpack option that takes an absolute path Walks webpack's own schema for every option reachable from the root that uses `absolutePath: true` - 34 of them, from `output.path` and `context` to the `module.rules` conditions and the `snapshot` path lists - and checks a `file://` URL validates for each, so the support is verified against the real consumer rather than the fixture schema alone. The options that require a relative path are covered too: the prefix must not make one of them accept an absolute path. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013wqLmVHkAGBsWQgXknEQCK * chore: add a changeset for the `file://` prefix Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013wqLmVHkAGBsWQgXknEQCK * chore: link the changeset to the pull request Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_013wqLmVHkAGBsWQgXknEQCK --------- Co-authored-by: Sage Abdullah <[email protected]> Co-authored-by: Claude Opus 5 <[email protected]>
Member
|
Sorry for big delay, fixed in the main with co-author, found some bugs on webpack side too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #209
What kind of change does this PR introduce?
This allows an optional
file://protocol prefix for absolute paths, such as those returned byimport.meta.resolve().Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
Not that I know of.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
I couldn't find docs for the absolute path functions, so I didn't add any.