refactor: show error message from jest-worker by pustovalov · Pull Request #203 · webpack/minimizer-webpack-plugin

pustovalov · 2019-12-27T18:16:46Z

This PR contains a:

Motivation / Use-Case

looks like bug in jest-worker

https://github.com/facebook/jest/blob/master/packages/jest-worker/src/workers/ChildProcessWorker.ts#L93

I think these changes will help to find a problem

Breaking Changes

Nope

Additional Info

jsf-clabot · 2019-12-27T18:16:48Z

All committers have signed the CLA.

codecov · 2019-12-27T18:18:55Z

Codecov Report

Merging #203 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   98.44%   98.45%   +<.01%     
==========================================
  Files           7        7              
  Lines         387      388       +1     
  Branches      155      156       +1     
==========================================
+ Hits          381      382       +1     
  Misses          6        6

Impacted Files	Coverage Δ
src/TaskRunner.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2da43...b29d3ef. Read the comment docs.

alexander-akait

Thanks

alexander-akait

Can we add test(s) where we can see what an error appears?

pustovalov · 2019-12-31T00:05:12Z

I will try

pustovalov · 2020-01-02T14:13:41Z

When writing a test, I found silent:false doesn’t work, thanks to this demo: https://github.com/tedconn/worker-jest-ts

forkOptions: {
    silent: false,
},

[~/Downloads/worker-jest-ts-master]$ npm test                                                                                                                                        [ruby-2.6.1]

> [email protected] test /Users/pavel/Downloads/worker-jest-ts-master
> jest --forceExit

 FAIL  src/__tests__/index.test.js
  invokes the compiler
    ✕ prints the right message (262ms)

  ● invokes the compiler › prints the right message

    Call retries were exceeded

      at ChildProcessWorker.initialize (node_modules/jest-worker/build/workers/ChildProcessWorker.js:193:21)

Test Suites: 1 failed, 1 total

Change silent: false to this one

if (worker.getStderr()) worker.getStderr().pipe(process.stderr)

result:

[~/Downloads/worker-jest-ts-master]$ npm test                                                                                                                                        [ruby-2.6.1]

> [email protected] test /Users/pavel/Downloads/worker-jest-ts-master
> jest --forceExit

/Users/pavel/Downloads/worker-jest-ts-master/src/compiler.ts:1
export async function compile() {
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (internal/modules/cjs/loader.js:1055:16)
    at Module._compile (internal/modules/cjs/loader.js:1103:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1159:10)
    at Module.load (internal/modules/cjs/loader.js:988:32)
    at Function.Module._load (internal/modules/cjs/loader.js:896:14)
    at Module.require (internal/modules/cjs/loader.js:1028:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at execMethod (/Users/pavel/Downloads/worker-jest-ts-master/node_modules/jest-worker/build/workers/processChild.js:128:16)
    at process.<anonymous> (/Users/pavel/Downloads/worker-jest-ts-master/node_modules/jest-worker/build/workers/processChild.js:64:7)
    at process.emit (events.js:305:20)
/Users/pavel/Downloads/worker-jest-ts-master/src/compiler.ts:1
export async function compile() {
^^^^^^

  invokes the compiler
    ✕ prints the right message (289ms)

  ● invokes the compiler › prints the right message

    Call retries were exceeded

      at ChildProcessWorker.initialize (node_modules/jest-worker/build/workers/ChildProcessWorker.js:193:21)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total

but even with if (worker.getStderr()) worker.getStderr().pipe(process.stderr) I did not find a way to write a test for this

If I put process.exit(1) to the worker.js, I see this an error:

  console.log src/TaskRunner.js:60
    er Error: Call retries were exceeded
        at ChildProcessWorker.initialize (/Users/pavel/terser-webpack-plugin/node_modules/jest-worker/build/workers/ChildProcessWorker.js:193:21)
        at ChildProcessWorker.onExit (/Users/pavel/terser-webpack-plugin/node_modules/jest-worker/build/workers/ChildProcessWorker.js:264:12)
        at ChildProcess.emit (events.js:305:20)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12) {
      type: 'WorkerError'
    }

I think we see this error because the process does not have enough memory and it crashes, maybe we can add some debug information to the
https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/src/TaskRunner.js#L47

something like this

const showMemoryUsage = (step = '') => {
  const used = process.memoryUsage().heapUsed / 1024 / 1024;
  console.log(`Memory used ${step}: ${Math.round(used * 100) / 100} MB`);
};

showMemoryUsage('on worker error');

alexander-akait · 2020-01-03T13:57:48Z

In theory crash can be not only because of memory, I think we can then avoid the tests, let's just add comments to the code, why are we doing this

pustovalov · 2020-01-06T23:35:27Z

Changed the code from silent: false to this implementation:
https://github.com/facebook/jest/blob/v24.9.0/packages/jest-runner/src/index.ts#L138

alexander-akait

Big thanks!

pustovalov force-pushed the jest-worker branch from 013757b to 16ccdd4 Compare December 27, 2019 19:52

alexander-akait previously approved these changes Dec 29, 2019

View reviewed changes

jamesgeorge007 previously approved these changes Dec 29, 2019

View reviewed changes

alexander-akait reviewed Dec 30, 2019

View reviewed changes

alexander-akait mentioned this pull request Jan 3, 2020

Process aborts with 'out of memory' when using 2.0.0 #143

Closed

pustovalov dismissed stale reviews from jamesgeorge007 and alexander-akait via c586c23 January 6, 2020 23:32

pustovalov force-pushed the jest-worker branch from 16ccdd4 to c586c23 Compare January 6, 2020 23:32

refactor: show error message from jest-worker

b29d3ef

pustovalov force-pushed the jest-worker branch from c586c23 to b29d3ef Compare January 7, 2020 02:42

alexander-akait approved these changes Jan 9, 2020

View reviewed changes

alexander-akait merged commit 3b28007 into webpack:master Jan 9, 2020

sokra mentioned this pull request Jan 14, 2020

chore(deps): bump terser-webpack-plugin from 2.3.1 to 2.3.2 webpack/webpack#10226

Closed

njradford mentioned this pull request Jan 16, 2020

Update terser-webpack-plugin to 2.3.2 rails/webpacker#2433

Merged

snyk-bot mentioned this pull request Mar 15, 2020

[Snyk] Upgrade terser-webpack-plugin from 2.2.1 to 2.3.5 drich7449/create-react-app#4

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: show error message from jest-worker#203

refactor: show error message from jest-worker#203
alexander-akait merged 1 commit into
webpack:masterfrom
pustovalov:jest-worker

pustovalov commented Dec 27, 2019 •

edited

Loading

Uh oh!

jsf-clabot commented Dec 27, 2019 •

edited

Loading

Uh oh!

codecov Bot commented Dec 27, 2019 •

edited

Loading

Uh oh!

alexander-akait left a comment

Uh oh!

alexander-akait left a comment

Uh oh!

pustovalov commented Dec 31, 2019

Uh oh!

pustovalov commented Jan 2, 2020

Uh oh!

alexander-akait commented Jan 3, 2020

Uh oh!

pustovalov commented Jan 6, 2020 •

edited

Loading

Uh oh!

alexander-akait left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

pustovalov commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation / Use-Case

Breaking Changes

Additional Info

Uh oh!

jsf-clabot commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

pustovalov commented Dec 31, 2019

Uh oh!

pustovalov commented Jan 2, 2020

Uh oh!

alexander-akait commented Jan 3, 2020

Uh oh!

pustovalov commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pustovalov commented Dec 27, 2019 •

edited

Loading

jsf-clabot commented Dec 27, 2019 •

edited

Loading

codecov Bot commented Dec 27, 2019 •

edited

Loading

pustovalov commented Jan 6, 2020 •

edited

Loading