fix: handle null module.layer in renderContentAsset

Vyazovoy · Vyazovoy · commit b73303223568 · 2026-03-05T17:00:24.000-05:00
Webpack's Module base class defaults `layer` to `null` when
`experiments.layers` is enabled and no explicit layer is assigned.

The existing check `typeof module.layer !== "undefined"` incorrectly
evaluates to `true` for `null` (since `typeof null` is `"object"`),
causing a crash when accessing `module.layer.length`.

Replace the check with `typeof module.layer === "string"` which
correctly handles both `null` and `undefined` while being more
precise about the expected type.
diff --git a/src/index.js b/src/index.js
@@ -1537,11 +1537,11 @@ class MiniCssExtractPlugin {
         if (
           module.media ||
           module.supports ||
-          typeof module.layer !== "undefined"
+          typeof module.layer === "string"
         ) {
           let atImportExtra = "";
 
-          const needLayer = typeof module.layer !== "undefined";
+          const needLayer = typeof module.layer === "string";
 
           if (needLayer) {
             atImportExtra +=
@@ -1577,7 +1577,7 @@ class MiniCssExtractPlugin {
           source.add(`@media ${module.media} {\n`);
         }
 
-        const needLayer = typeof module.layer !== "undefined";
+        const needLayer = typeof module.layer === "string";
 
         if (needLayer) {
           source.add(
diff --git a/test/cases/simple-with-experiments-layers/expected/main.css b/test/cases/simple-with-experiments-layers/expected/main.css
@@ -0,0 +1,4 @@
+body {
+  background: red;
+}
+
diff --git a/test/cases/simple-with-experiments-layers/index.js b/test/cases/simple-with-experiments-layers/index.js
@@ -0,0 +1 @@
+import "./style.css";
diff --git a/test/cases/simple-with-experiments-layers/style.css b/test/cases/simple-with-experiments-layers/style.css
@@ -0,0 +1,3 @@
+body {
+  background: red;
+}
diff --git a/test/cases/simple-with-experiments-layers/webpack.config.js b/test/cases/simple-with-experiments-layers/webpack.config.js
@@ -0,0 +1,21 @@
+import Self from "../../../src";
+
+module.exports = {
+  entry: "./index.js",
+  experiments: {
+    layers: true,
+  },
+  module: {
+    rules: [
+      {
+        test: /\.css$/,
+        use: [Self.loader, "css-loader"],
+      },
+    ],
+  },
+  plugins: [
+    new Self({
+      filename: "[name].css",
+    }),
+  ],
+};

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +body {
 +  background: red;
 +}
++