fix: better configuration for module/commonjs/dirty format (#51)

alexander-akait · web-flow · commit 7de7ddf4cfcd · 2025-06-24T19:21:29.000+03:00
diff --git a/configs.js b/configs.js
@@ -4,6 +4,7 @@ import { globalIgnores } from "eslint/config";
 import semver from "semver";
 import configs from "./configs/index.js";
 import ignorePaths from "./ignore-paths.js";
+import { typescriptExtensions } from "./configs/utils/extensions.js";
 
 const SKIP_TIME = 5000;
 
@@ -249,7 +250,15 @@ function getTypescriptConfig() {
 
 	return [
 		configs["typescript/recommended"],
-		isStrict ? { rules: { strict: "off" } } : {},
+		isStrict
+			? {
+					files: [
+						`**/*.{${typescriptExtensions.map((item) => item.slice(1)).join(",")}}`,
+					],
+					ignores: ["**/*.d.ts"],
+					rules: { strict: "off" },
+				}
+			: {},
 	];
 }
 
diff --git a/configs/node.js b/configs/node.js
@@ -149,14 +149,12 @@ async function getCommonJSConfig() {
 			"n/no-path-concat": "error",
 			"import/extensions": [
 				"error",
-				"never",
+				"always",
 				{
 					ignorePackages: true,
+					checkTypeImports: true,
 					pattern: {
-						ts: "always",
-						cts: "always",
-						mts: "always",
-						tsx: "always",
+						js: "never",
 					},
 				},
 			],
diff --git a/eslint.config.js b/eslint.config.js
@@ -1,8 +1,27 @@
 import { defineConfig } from "eslint/config";
 import config from "../eslint-config-webpack/index.js";
+import configs from "../eslint-config-webpack/configs.js";
 
 export default defineConfig([
 	{
+		ignores: [
+			"./validation/commonjs-package/**/*",
+			"./validation/module-package/**/*",
+			"./validation/dirty-package/**/*",
+		],
 		extends: [config],
 	},
+	// For test purposes
+	{
+		files: ["./validation/commonjs-package/**/*"],
+		extends: [configs["recommended-commonjs"]],
+	},
+	{
+		files: ["./validation/module-package/**/*"],
+		extends: [configs["recommended-module"]],
+	},
+	{
+		files: ["./validation/dirty-package/**/*"],
+		extends: [configs["recommended-dirty"]],
+	},
 ]);
diff --git a/validation/code.cjs b/validation/code.cjs
@@ -6,7 +6,7 @@ const myOtherCode = require("./module.js");
 const otherSum = require("./module");
 
 // eslint-disable-next-line import/no-unresolved
-require("./unknown");
+require("./unknown.unknown");
 
 require("./style.css");
 
diff --git a/validation/commonjs-package/file.js b/validation/commonjs-package/file.js
@@ -0,0 +1,23 @@
+"use strict";
+
+const mod = require("./my-module");
+const otherMod = require("./other-module.cjs");
+// eslint-disable-next-line import/extensions
+const modAgain = require("./my-module.js");
+
+const foo = 1;
+const bar = 2;
+
+/**
+ * @param {number} a a
+ * @param {number} b b
+ * @returns {number} sum
+ */
+function sum(a, b) {
+	return a + b;
+}
+
+sum(foo, bar);
+sum(mod.a, mod.b);
+sum(otherMod.a, otherMod.b);
+sum(modAgain.a, modAgain.b);
diff --git a/validation/commonjs-package/my-module.js b/validation/commonjs-package/my-module.js
@@ -0,0 +1,4 @@
+"use strict";
+
+module.exports.a = 1;
+module.exports.b = 2;
diff --git a/validation/commonjs-package/other-module.cjs b/validation/commonjs-package/other-module.cjs
@@ -0,0 +1,4 @@
+"use strict";
+
+module.exports.a = 1;
+module.exports.b = 2;
diff --git a/validation/commonjs-package/package.json b/validation/commonjs-package/package.json
@@ -0,0 +1,5 @@
+{
+  "name": "commonjs-package",
+  "description": "Test",
+  "version": "1.0.0"
+}
diff --git a/validation/dirty-package/file.js b/validation/dirty-package/file.js
@@ -0,0 +1,21 @@
+import { a, b } from "./my-module.js";
+import otherMod from "././other-module.cjs";
+
+const commonJSModule = require("./module-js-common.js");
+
+const foo = 1;
+const bar = 2;
+
+/**
+ * @param {number} a a
+ * @param {number} b b
+ * @returns {number} sum
+ */
+function sum(a, b) {
+	return a + b;
+}
+
+sum(foo, bar);
+sum(a, b);
+sum(otherMod.a, otherMod.b);
+sum(commonJSModule.a, commonJSModule.b);
diff --git a/validation/dirty-package/module-js-common.js b/validation/dirty-package/module-js-common.js
@@ -0,0 +1 @@
+module.exports = 100;
diff --git a/validation/dirty-package/my-module.js b/validation/dirty-package/my-module.js
@@ -0,0 +1,2 @@
+export const a = 1;
+export const b = 2;
diff --git a/validation/dirty-package/other-module.cjs b/validation/dirty-package/other-module.cjs
@@ -0,0 +1,4 @@
+"use strict";
+
+module.exports.a = 1;
+module.exports.b = 2;
diff --git a/validation/dirty-package/package.json b/validation/dirty-package/package.json
@@ -0,0 +1,5 @@
+{
+  "name": "dirty-package",
+  "description": "Test",
+  "version": "1.0.0"
+}
diff --git a/validation/module-package/cjs-module.cjs b/validation/module-package/cjs-module.cjs
@@ -0,0 +1,4 @@
+"use strict";
+
+module.exports.a = 1;
+module.exports.b = 2;
diff --git a/validation/module-package/file.js b/validation/module-package/file.js
@@ -0,0 +1,21 @@
+import { a, b } from "./my-module.js";
+import otherMod from "././other-module.cjs";
+
+// eslint-disable-next-line no-unused-vars, no-undef
+const commonJSModule = require("./cjs-module.cjs");
+
+const foo = 1;
+const bar = 2;
+
+/**
+ * @param {number} a a
+ * @param {number} b b
+ * @returns {number} sum
+ */
+function sum(a, b) {
+	return a + b;
+}
+
+sum(foo, bar);
+sum(a, b);
+sum(otherMod.a, otherMod.b);
diff --git a/validation/module-package/my-module.js b/validation/module-package/my-module.js
@@ -0,0 +1,2 @@
+export const a = 1;
+export const b = 2;
diff --git a/validation/module-package/other-module.cjs b/validation/module-package/other-module.cjs
@@ -0,0 +1,4 @@
+"use strict";
+
+module.exports.a = 1;
+module.exports.b = 2;
diff --git a/validation/module-package/package.json b/validation/module-package/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "module-package",
+  "description": "Test",
+  "version": "1.0.0",
+  "type": "module"
+}
