fix: do not apply typescript rules when emit disabled (#48)

alexander-akait · web-flow · commit 5bed1ab9e3a8 · 2025-06-23T22:44:11.000+03:00
diff --git a/configs.js b/configs.js
@@ -139,6 +139,7 @@ function getJavascriptConfig() {
 		const minVersion = semver.minVersion(packageJson.engines.node).major;
 
 		// https://node.green/
+		// https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping
 		switch (minVersion) {
 			case 6: {
 				const config = { ...configs["javascript/es2016"] };
@@ -229,6 +230,17 @@ function getTypescriptConfig() {
 	}
 
 	const tsconfigJson = getJsonFile("tsconfig.json");
+
+	const isNoEmitEnabled =
+		(tsconfigJson &&
+			tsconfigJson.compilerOptions &&
+			tsconfigJson.compilerOptions.noEmit) ||
+		false;
+
+	if (isNoEmitEnabled) {
+		return {};
+	}
+
 	const isStrict =
 		(tsconfigJson &&
 			tsconfigJson.compilerOptions &&
diff --git a/configs/javascript.js b/configs/javascript.js
@@ -1164,6 +1164,7 @@ function getConfig(esVersion) {
 		...javascriptConfig.configs.recommended,
 		name: `javascript/es${esVersion}`,
 		files: [`**/*.{${allExtensions.map((item) => item.slice(1)).join(",")}}`],
+		ignores: ["**/*.d.ts"],
 		settings: {
 			"import/extensions": allExtensions,
 			"import/ignore": [
diff --git a/configs/node.js b/configs/node.js
@@ -117,6 +117,8 @@ const commonRules = {
 
 let nodePlugin;
 
+const ignores = ["**/*.d.ts"];
+
 /**
  * @returns {Promise<Record<string, string>>} config
  */
@@ -136,6 +138,7 @@ async function getCommonJSConfig() {
 	return {
 		...nodeConfig,
 		name: "node/commonjs",
+		ignores,
 		plugins: {
 			...nodeConfig.plugins,
 			import: importPlugin,
@@ -182,6 +185,7 @@ async function getModuleConfig() {
 	return {
 		...nodeConfig,
 		name: "node/module",
+		ignores,
 		plugins: {
 			...nodeConfig.plugins,
 			import: importPlugin,
@@ -221,6 +225,7 @@ async function getDirtyConfig() {
 			n: nodePlugin,
 			import: importPlugin,
 		},
+		ignores: [...new Set([...commonjsConfig.ignores, ...moduleConfig.ignores])],
 		languageOptions: {
 			sourceType: "module",
 			parserOptions: {
diff --git a/configs/typescript.js b/configs/typescript.js
@@ -310,6 +310,7 @@ async function getTypescriptRecommendedConfig() {
 		files: [
 			`**/*.{${typescriptExtensions.map((item) => item.slice(1)).join(",")}}`,
 		],
+		ignores: ["**/*.d.ts"],
 		languageOptions: {
 			parser: baseConfig.languageOptions.parser,
 		},
diff --git a/validation/module.d.ts b/validation/module.d.ts
@@ -0,0 +1,2 @@
+export function getArrayLength(arr: any[]): number;
+export const maxInterval: 12;

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+export function getArrayLength(arr: any[]): number;`
	`2`	`+export const maxInterval: 12;`