feat: enable rule for order of imports and exports (#59)

alexander-akait · web-flow · commit 387c167b2883 · 2025-06-27T18:46:07.000+03:00
diff --git a/configs.js b/configs.js
@@ -3,8 +3,8 @@ import path from "node:path";
 import { globalIgnores } from "eslint/config";
 import semver from "semver";
 import configs from "./configs/index.js";
-import ignorePaths from "./ignore-paths.js";
 import { typescriptExtensions } from "./configs/utils/extensions.js";
+import ignorePaths from "./ignore-paths.js";
 
 const SKIP_TIME = 5000;
 
diff --git a/configs/browser.js b/configs/browser.js
@@ -1,5 +1,5 @@
-import globals from "globals";
 import importPlugin from "eslint-plugin-import";
+import globals from "globals";
 
 const recommendedBrowserConfig = {
 	languageOptions: {
diff --git a/configs/index.js b/configs/index.js
@@ -3,9 +3,9 @@ import javascriptConfig from "./javascript.js";
 import jestConfig from "./jest.js";
 import markdownConfig from "./markdown.js";
 import nodeConfig from "./node.js";
+import packageJSON from "./package-json.js";
 import stylisticConfig from "./stylistic.js";
 import typescriptConfig from "./typescript.js";
-import packageJSON from "./package-json.js";
 
 const configs = {
 	...browserConfig,
diff --git a/configs/javascript.js b/configs/javascript.js
@@ -1,7 +1,7 @@
-import globals from "globals";
 import javascriptConfig from "@eslint/js";
-import unicornPlugin from "eslint-plugin-unicorn";
 import importPlugin from "eslint-plugin-import";
+import unicornPlugin from "eslint-plugin-unicorn";
+import globals from "globals";
 import { allExtensions } from "./utils/extensions.js";
 
 const possibleProblems = {
@@ -1141,21 +1141,20 @@ const importRules = {
 	// No need
 	// "import/no-unassigned-import": "off",
 
-	// No need
-	// TODO consider this in the future
-	// "import/order": [
-	//   "warn",
-	//   {
-	//     groups: [
-	//       "builtin",
-	//       "external",
-	//       "internal",
-	//       "parent",
-	//       "sibling",
-	//       "index",
-	//     ]
-	//   },
-	// ],
+	"import/order": [
+		"error",
+		{
+			named: {
+				enabled: true,
+				import: true,
+				export: true,
+				require: true,
+				cjsExports: true,
+				types: "mixed",
+			},
+			alphabetize: { order: "asc" },
+		},
+	],
 
 	// No need
 	// "import/prefer-default-export": "off",
diff --git a/configs/node.js b/configs/node.js
@@ -1,5 +1,5 @@
-import globals from "globals";
 import importPlugin from "eslint-plugin-import";
+import globals from "globals";
 
 const commonRules = {
 	// No need
diff --git a/configs/stylistic.js b/configs/stylistic.js
@@ -1,6 +1,6 @@
+import stylisticPlugin from "@stylistic/eslint-plugin";
 import prettierPlugin from "eslint-plugin-prettier";
 import prettierConfig from "eslint-plugin-prettier/recommended";
-import stylisticPlugin from "@stylistic/eslint-plugin";
 
 const recommendedConfig = {
 	...prettierConfig,
diff --git a/configs/utils/extensions.js b/configs/utils/extensions.js
@@ -2,4 +2,4 @@ const javascriptExtensions = [".js", ".cjs", ".mjs", ".jsx"];
 const typescriptExtensions = [".ts", ".cts", ".mts", ".tsx"];
 const allExtensions = [...javascriptExtensions, ...typescriptExtensions];
 
-export { javascriptExtensions, typescriptExtensions, allExtensions };
+export { allExtensions, javascriptExtensions, typescriptExtensions };
diff --git a/eslint.config.js b/eslint.config.js
@@ -1,6 +1,6 @@
 import { defineConfig } from "eslint/config";
-import config from "../eslint-config-webpack/index.js";
 import configs from "../eslint-config-webpack/configs.js";
+import config from "../eslint-config-webpack/index.js";
 
 export default defineConfig([
 	{
diff --git a/plugins/package-json/index.js b/plugins/package-json/index.js
@@ -43,6 +43,6 @@ const plugin = {
 	rules,
 };
 
-export { rules, configs };
+export { configs, rules };
 
 export default plugin;
diff --git a/validation/code.cjs b/validation/code.cjs
@@ -1,14 +1,7 @@
 "use strict";
 
-const code = require("./module.cjs");
-// eslint-disable-next-line no-unused-vars, import/extensions
-const myOtherCode = require("./module.js");
 const otherSum = require("./module");
-
-// eslint-disable-next-line import/no-unresolved
-require("./unknown.unknown");
-
-require("./style.css");
+const code = require("./module.cjs");
 
 const { aaa } = require("./module.cjs");
 
@@ -18,6 +11,14 @@ const { bbb } = require("./module.cjs");
 
 otherSum(bbb, 2);
 
+// eslint-disable-next-line no-unused-vars, import/extensions
+const myOtherCode = require("./module.js");
+
+// eslint-disable-next-line import/no-unresolved
+require("./unknown.unknown");
+
+require("./style.css");
+
 code();
 otherSum(1, 2);
 
diff --git a/validation/code.js b/validation/code.js
@@ -1,8 +1,9 @@
 import { CLIEngine, linter } from "eslint";
 import sumFn from "./module.js";
-import * as names from "./named-exports.js";
 // eslint-disable-next-line import/named, no-duplicate-imports
 import { notFoo } from "./module.js";
+import * as names from "./named-exports.js";
+
 // eslint-disable-next-line no-unused-vars, import/extensions, import/no-unresolved
 import { myVar } from "./without-extension";
 
@@ -918,12 +919,12 @@ timer = setInterval(initialize, 100);
 
 export { foo, handler };
 export {
+	MyClass,
 	age as ageExport,
 	arrayVariable as arrayVariableExport,
+	callbackInPromise,
 	fooAsync,
 	fooFuncExtra,
-	MyClass,
-	callbackInPromise,
 	promiseInCallback,
 };
 
diff --git a/validation/code.mjs b/validation/code.mjs
@@ -1,9 +1,9 @@
-import code from "./module.cjs";
-import myOtherCode from "./module.js";
 // eslint-disable-next-line import/extensions
 import otherSum from "./module";
+import code from "./module.cjs";
 // eslint-disable-next-line no-duplicate-imports
 import { aaa, bbb } from "./module.cjs";
+import myOtherCode from "./module.js";
 
 // eslint-disable-next-line import/no-unresolved
 import("./unknown.ext");
diff --git a/validation/commonjs-package/file.js b/validation/commonjs-package/file.js
@@ -1,9 +1,9 @@
 "use strict";
 
 const mod = require("./my-module");
-const otherMod = require("./other-module.cjs");
 // eslint-disable-next-line import/extensions
 const modAgain = require("./my-module.js");
+const otherMod = require("./other-module.cjs");
 
 require("../typescript-node-support/my-other-code.ts");
 require("../typescript-node-support/my-other-code");
diff --git a/validation/dirty-package/file.js b/validation/dirty-package/file.js
@@ -1,5 +1,5 @@
-import { a, b } from "./my-module.js";
 import otherMod from "././other-module.cjs";
+import { a, b } from "./my-module.js";
 
 const commonJSModule = require("./module-js-common.js");
 
diff --git a/validation/file.md b/validation/file.md
@@ -13,8 +13,8 @@ run();
 ```
 
 ```js
-import { fileURLToPath } from "node:url";
 import { dirname } from "node:path";
+import { fileURLToPath } from "node:url";
 
 const __filename = fileURLToPath(import.meta.url);
 
diff --git a/validation/import-export-order/a.js b/validation/import-export-order/a.js
@@ -0,0 +1 @@
+export default "a";
diff --git a/validation/import-export-order/b.js b/validation/import-export-order/b.js
@@ -0,0 +1 @@
+export default "b";
diff --git a/validation/import-export-order/c.js b/validation/import-export-order/c.js
@@ -0,0 +1 @@
+export default "c";
diff --git a/validation/import-export-order/d.js b/validation/import-export-order/d.js
@@ -0,0 +1 @@
+export default "d";
diff --git a/validation/import-export-order/e.js b/validation/import-export-order/e.js
@@ -0,0 +1 @@
+export default "d";
diff --git a/validation/import-export-order/f.js b/validation/import-export-order/f.js
@@ -0,0 +1,7 @@
+/* eslint-disable id-length */
+
+const a = "a";
+const b = "b";
+const c = "c";
+
+export { a, b, c };
diff --git a/validation/import-export-order/g.js b/validation/import-export-order/g.js
@@ -0,0 +1,7 @@
+/* eslint-disable id-length */
+
+const a = "a";
+const b = "b";
+const c = "c";
+
+export { a, b, c };
diff --git a/validation/import-export-order/h.js b/validation/import-export-order/h.js
@@ -0,0 +1 @@
+export default "h";
diff --git a/validation/import-export-order/i.ts b/validation/import-export-order/i.ts
@@ -0,0 +1,5 @@
+export default "i";
+
+export type A = "A";
+export type B = "B";
+export type C = "C";
diff --git a/validation/import-export-order/index.cjs b/validation/import-export-order/index.cjs
@@ -0,0 +1,41 @@
+"use strict";
+
+/* eslint-disable id-length */
+
+const a = require("./a");
+const b = require("./b");
+const c = require("./c");
+const e = require("./e");
+/* eslint-disable-next-line import/order */
+const d = require("./d");
+const { a: a1, b: b1, c: c1 } = require("./f");
+/* eslint-disable-next-line import/order */
+const { c: c2, a: a2, b: b2 } = require("./g");
+const z = require("./h");
+
+/**
+ * @template T
+ * @param {T} val value
+ * @returns {T} value
+ */
+function get(val) {
+	return val;
+}
+
+get(a);
+get(b);
+get(c);
+get(d);
+get(e);
+get(a1);
+get(b1);
+get(c1);
+get(a2);
+get(b2);
+get(c2);
+get(z);
+
+module.exports.a = "a";
+module.exports.c = "c";
+// eslint-disable-next-line import/order
+module.exports.b = "b";
diff --git a/validation/import-export-order/index.js b/validation/import-export-order/index.js
@@ -0,0 +1,45 @@
+/* eslint-disable id-length */
+
+import a from "./a.js";
+import b from "./b.js";
+import c from "./c.js";
+import e from "./e.js";
+/* eslint-disable-next-line import/order */
+import d from "./d.js";
+import { a as a1, b as b1, c as c1 } from "./f.js";
+/* eslint-disable-next-line import/order */
+import { c as c2, a as a2, b as b2 } from "./g.js";
+import z from "./h.js";
+
+/**
+ * @template T
+ * @param {T} val value
+ * @returns {T} value
+ */
+function get(val) {
+	return val;
+}
+
+get(a);
+get(b);
+get(c);
+get(d);
+get(e);
+get(a1);
+get(b1);
+get(c1);
+get(a2);
+get(b2);
+get(c2);
+get(z);
+
+export const p = "p";
+export const q = "q";
+export const r = "r";
+
+const s = "s";
+const t = "t";
+const u = "u";
+
+// eslint-disable-next-line import/order
+export { s, u, t };
diff --git a/validation/import-export-order/j.js b/validation/import-export-order/j.js
@@ -0,0 +1 @@
+export default "i";
diff --git a/validation/import-export-order/ts-index.ts b/validation/import-export-order/ts-index.ts
@@ -0,0 +1,55 @@
+/* eslint-disable id-length */
+
+import a from "./a.js";
+import b from "./b.js";
+import c from "./c.js";
+import e from "./e.js";
+/* eslint-disable-next-line import/order */
+import d from "./d.js";
+import { a as a1, b as b1, c as c1 } from "./f.js";
+/* eslint-disable-next-line import/order */
+import { c as c2, a as a2, b as b2 } from "./g.js";
+import z from "./h.js";
+import { type A, type B, type C } from "./i.js";
+import j from "./j.js";
+
+const A: A = "A";
+const B: B = "B";
+const C: C = "C";
+
+/**
+ * @template T
+ * @param {T} val value
+ * @returns {T} value
+ */
+function get(val) {
+	return val;
+}
+
+get(a);
+get(b);
+get(c);
+get(d);
+get(e);
+get(a1);
+get(b1);
+get(c1);
+get(a2);
+get(b2);
+get(c2);
+get(z);
+get(j);
+get(A);
+get(B);
+get(C);
+
+export const p = "p";
+export const q = "q";
+export const r = "r";
+
+const s = "s";
+const t = "t";
+const u = "u";
+
+// eslint-disable-next-line import/order
+export { s, u, t };
diff --git a/validation/module-package/file.js b/validation/module-package/file.js
@@ -1,5 +1,5 @@
-import { a, b } from "./my-module.js";
 import otherMod from "././other-module.cjs";
+import { a, b } from "./my-module.js";
 
 // eslint-disable-next-line no-unused-vars, no-undef
 const commonJSModule = require("./cjs-module.cjs");
diff --git a/validation/module.cjs b/validation/module.cjs
diff --git a/validation/my-ts-code.ts b/validation/my-ts-code.ts
diff --git a/validation/typescript-node-support/my-other-code.cts b/validation/typescript-node-support/my-other-code.cts
diff --git a/validation/typescript-node-support/my-other-code.mts b/validation/typescript-node-support/my-other-code.mts
diff --git a/validation/typescript-node-support/my-other-code.ts b/validation/typescript-node-support/my-other-code.ts

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import { defineConfig } from "eslint/config";`
`2`		`-import config from "../eslint-config-webpack/index.js";`
`3`	`2`	`import configs from "../eslint-config-webpack/configs.js";`
	`3`	`+import config from "../eslint-config-webpack/index.js";`
`4`	`4`
`5`	`5`	`export default defineConfig([`
`6`	`6`	`{`