Skip to content

Commit 38a5aa8

Browse files
ci: disable npm cache for Node 10 test leg (#603)
1 parent fcb3e3f commit 38a5aa8

4 files changed

Lines changed: 39 additions & 14 deletions

File tree

‎.github/workflows/test.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ jobs:
5050
with:
5151
node-version: ${{ matrix.node-version }}
5252
architecture: ${{ steps.calculate_architecture.outputs.result }}
53-
cache: npm
53+
# Legacy Node (10-16) reinstalls deps after dropping/bypassing
54+
# package-lock.json, so there's no lockfile for setup-node's npm
55+
# cache to key on.
56+
cache: ${{ (matrix.node-version == '10.x' || matrix.node-version == '12.x' || matrix.node-version == '14.x' || matrix.node-version == '16.x') && '' || 'npm' }}
5457

5558
- name: Install dependencies
5659
shell: bash

‎benchmark/cases/prefer-absolute/index.bench.mjs‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ export default function register(bench, { fixtureDir }) {
3737
path.join(fixtureDir, "assets/data/schema"),
3838
];
3939

40+
// Warm resolves allocate only a few KB, below CodSpeed's memory-mode noise
41+
// floor; repeat the batch so measured allocation clears it.
42+
const REPEAT = 20;
43+
4044
const resolve = (req) =>
4145
new Promise((resolve, reject) => {
4246
resolver.resolve({}, from, req, {}, (err, result) => {
@@ -47,8 +51,10 @@ export default function register(bench, { fixtureDir }) {
4751
});
4852

4953
bench.add("prefer-absolute: absolute paths (warm)", async () => {
50-
for (const req of requests) {
51-
await resolve(req);
54+
for (let r = 0; r < REPEAT; r++) {
55+
for (const req of requests) {
56+
await resolve(req);
57+
}
5258
}
5359
});
5460
}

‎benchmark/cases/symlinks/index.bench.mjs‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ export default function register(bench, { fixtureDir }) {
5757

5858
const requests = names.map((n) => `./linked/${n}`);
5959

60+
// Warm resolves allocate only a few KB, below CodSpeed's memory-mode noise
61+
// floor; repeat the batch so measured allocation clears it.
62+
const REPEAT = 20;
63+
6064
const resolveWith = (resolver, req) =>
6165
new Promise((resolve, reject) => {
6266
resolver.resolve({}, fixtureDir, req, {}, (err, result) => {
@@ -67,14 +71,18 @@ export default function register(bench, { fixtureDir }) {
6771
});
6872

6973
bench.add("symlinks: follow symlinks=true (warm)", async () => {
70-
for (const req of requests) {
71-
await resolveWith(symlinkResolver, req);
74+
for (let r = 0; r < REPEAT; r++) {
75+
for (const req of requests) {
76+
await resolveWith(symlinkResolver, req);
77+
}
7278
}
7379
});
7480

7581
bench.add("symlinks: symlinks=false (warm)", async () => {
76-
for (const req of requests) {
77-
await resolveWith(noSymlinkResolver, req);
82+
for (let r = 0; r < REPEAT; r++) {
83+
for (const req of requests) {
84+
await resolveWith(noSymlinkResolver, req);
85+
}
7886
}
7987
});
8088
}

‎benchmark/cases/unsafe-cache/index.bench.mjs‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,19 +58,27 @@ export default function register(bench, { fixtureDir }) {
5858
});
5959
});
6060

61-
// Three passes per iteration so cache hits dominate the hot case.
61+
// Three passes per iteration so cache hits dominate the hot case. REPEAT
62+
// amplifies total allocation above CodSpeed's memory-mode noise floor
63+
// without changing the 3-pass cache-hit pattern.
64+
const REPEAT = 20;
65+
6266
bench.add("unsafe-cache: ON, 3x repeat", async () => {
63-
for (let pass = 0; pass < 3; pass++) {
64-
for (const req of requests) {
65-
await resolveWith(cachedResolver, req);
67+
for (let r = 0; r < REPEAT; r++) {
68+
for (let pass = 0; pass < 3; pass++) {
69+
for (const req of requests) {
70+
await resolveWith(cachedResolver, req);
71+
}
6672
}
6773
}
6874
});
6975

7076
bench.add("unsafe-cache: OFF, 3x repeat", async () => {
71-
for (let pass = 0; pass < 3; pass++) {
72-
for (const req of requests) {
73-
await resolveWith(uncachedResolver, req);
77+
for (let r = 0; r < REPEAT; r++) {
78+
for (let pass = 0; pass < 3; pass++) {
79+
for (const req of requests) {
80+
await resolveWith(uncachedResolver, req);
81+
}
7482
}
7583
}
7684
});

0 commit comments

Comments
 (0)