Support repeatable directives#643
Merged
vladar merged 9 commits intowebonyx:masterfrom Jun 8, 2020
spawnia:support-repeatable-directives
Merged
Support repeatable directives#643vladar merged 9 commits intowebonyx:masterfrom spawnia:support-repeatable-directives
vladar merged 9 commits intowebonyx:masterfrom
spawnia:support-repeatable-directives
Conversation
Collaborator
Author
|
@simPod have you had a chance to review this PR yet? |
Collaborator
simPod
reviewed
Apr 27, 2020
simPod
reviewed
Apr 27, 2020
Co-Authored-By: Šimon Podlipský <[email protected]>
# Conflicts: # phpstan-baseline.neon # src/Type/Introspection.php # src/Utils/SchemaPrinter.php # src/Validator/Rules/UniqueDirectivesPerLocation.php
Member
|
@spawnia Is it ready for merging? (just to make sure) |
Collaborator
Author
Yes. I just checked if there are breaking changes we might want to mention, haven't found any. |
vladar
approved these changes
Jun 8, 2020
Member
vladar
left a comment
vladar
left a comment
There was a problem hiding this comment.
Awesome! This looks solid, so let's merge it! 🚢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #608
See graphql/graphql-js#1965