Merged
Conversation
BruceDai
reviewed
Nov 22, 2023
BruceDai
reviewed
Nov 22, 2023
BruceDai
reviewed
Nov 22, 2023
BruceDai
reviewed
Nov 22, 2023
BruceDai
reviewed
Nov 22, 2023
fdwr
reviewed
Nov 23, 2023
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
LGTM barring comments. Thanks for adding the conditional selection operator Mei.
Please enter the commit message for your changes. Lines starting
BruceDai
reviewed
Nov 27, 2023
Contributor
|
@Mei0211 Thanks for your update, LGTM. |
fdwr
reviewed
Nov 29, 2023
| */ | ||
| export function where(condition, trueValues, falseValues) { | ||
| const trueValuesReshape = trueValues.shape.length === 0 ? | ||
| new Scalar(trueValues.data) :trueValues; |
There was a problem hiding this comment.
Suggested change
| new Scalar(trueValues.data) :trueValues; | |
| new Scalar(trueValues.data) : trueValues; |
Nit for when you touch this file in the future...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BruceDai @huningxin @fdwr @mingmingtasd PTAL, thanks.