Correct pad scalar rank inconsistency#894
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Sep 30, 2025
Merged
Conversation
huningxin
approved these changes
Sep 30, 2025
github-actions bot
added a commit
that referenced
this pull request
Sep 30, 2025
SHA: 0f6cae2 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to zolkis/webnn
that referenced
this pull request
Oct 8, 2025
SHA: 0f6cae2 Reason: push, by zolkis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #893. The spec says pad's
opSupportLimitssupport input ranks from 0 to N, and the Chromium implementation see PR supports scalarpad(acts as nop, like an emptytransposeortilewould), but this one algorithm step says it doesn't. So, resolve the inconsistency by deleting that line.Preview | Diff