Conversation
Use distinct actors "web author", "user", and "implementer". Use "encouraged to" when RFC 2119 key words do not apply. Based on accessibility review feedback: w3c/a11y-request#105
0879c27 to
e760ec1
Compare
|
Looping in the editors @huningxin @fdwr to review the overall fit into the spec structure. Defer to a11y experts @matatk et al. to review the actual a11y substance. |
fdwr
left a comment
There was a problem hiding this comment.
Just grammar/spelling else LGTM.
Co-authored-by: Dwayne Robinson <[email protected]>
Co-authored-by: Dwayne Robinson <[email protected]>
Co-authored-by: Dwayne Robinson <[email protected]>
|
This looks great, thank you. Just a couple of things - the first one does need to be changed:
|
|
Please could you add the "a11y-tracker" label to this PR? That'll enable APA to keep updated on it automatically; thanks! |
Mermaid Live Editor export produces an invalid SVG. To fix this, we apply the following patch: perl -pi -e 's/ / /g' webnn_arch.png This replaces all non-breaking space character entity references with numeric entity references   Mermaid syntax does not support numeric entity references, so we need to rely on this patch if we want to be white space perfect. Consider: Core ML => Core ML Mermaid source used to produce this SVG: ```mermaid %%{ init : { "look" : "handDrawn", "theme" : "neo-dark" }}%% flowchart TD subgraph Models Model[ONNX, TensorFlow, PyTorch] end subgraph Frameworks Framework(ONNX Runtime Web, LiteRT) end subgraph Browser_APIs[Browser APIs] Wasm WebNN WebGPU end subgraph Native_ML_APIs[Native ML APIs] MLAPI[DirectML / LiteRT / Core ML] end subgraph Hardware CPU NPU GPU end Model --> Framework Framework --> Wasm Framework ==> WebNN Framework --> WebGPU Wasm --> CPU WebNN ==> MLAPI WebGPU --> GPU MLAPI ==> CPU MLAPI ==> NPU MLAPI ==> GPU ```
The SVG did not render as expected when embedded in markdown.
This commit comprehensively updates the device selection explainer to reflect the latest discussions, API changes, and community feedback. Key changes include: - Updated Introduction and History sections to accurately reflect the removal of `MLDeviceType` from `MLContextOptions` (following PR #809) and the shift towards hint-based, implementation-led device selection. - Clarified the impact of key issues (#749, #302, #350) and PRs (#809, #824, #855) on the device selection strategy. - Ensured the "Key use cases and requirements" section aligns with the current API, incorporating the device preference use cases from PR #855. - Updated JavaScript examples in "Scenarios, examples, design discussion" to be consistent with the current API, marking future/hypothetical features (like `opSupportLimitsPerDevice()` and a `fallback` option) with explanatory notes. - Added new open questions based on recent discussions (e.g., issue #836, PR #854 regarding querying actual device usage). - Refined the "Background thoughts" section, particularly the "Example Hardware Selection Guide," adding an editor's note about ongoing discussions (PR #860). - Corrected the "Considered alternatives" and "Minimum Viable Solution" sections to accurately represent the current and past approaches. - Updated the "Next Phase Device Selection Solution" to clarify the status of proposals like `querySupport` (issue #815) and the investigation of `graph.devices` (issue #836, PR #854). - Performed a full proofread, correcting grammar, typos, and markdown formatting for improved clarity and consistency throughout the document. Signed-off-by: Zoltan Kis <[email protected]> With thanks to Jules for proofreading: Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
@matatk, belated thank you for your review. I've updated the WCAG reference to the unversioned one. The privacy implications for the background blur for real-time video processing is an application-level consideration when WebNN is used to implement this functionality. The browser implementation cannot intervene other than gate the access (via a permission prompt) to the camera entirely. That said, if you have some proposed text, happy to integrate. Otherwise we consider these a11y considerations good to be merged, and thank you for the contribution. |
|
(FTR: merged as discussed today at https://www.w3.org/2025/08/14-webmachinelearning-minutes.html#1e28) |
SHA: 2c0f3a0 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Use distinct actors "web author", "user", and "implementer". Use "encouraged to" when RFC 2119 key words do not apply.
Based on accessibility review feedback:
w3c/a11y-request#105
PTAL @matatk
Preview | Diff