Merged
Conversation
mwyrzykowski
approved these changes
Jun 5, 2025
Collaborator
Author
👍 I'll give it a few days for others to look at too lest they have feedback. 🔍⏳ FYI @reillyeon @philloooo. |
anssiko
approved these changes
Jun 6, 2025
anssiko
pushed a commit
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quantizeLinearemulation step.partial interface MLGraphBuilder { ... + MLOperand roundEven(MLOperand input, optional MLOperatorOptions options = {}); ... };Mappings to backend functions:
RHEround halves to nearest even:rounding mode behaves inconsistently depending on whether it goes through the NPU vs GPU, but it should be consistently emulatable viaelementwise_binary.sub(x, elementwise_binary.mod(x, 1.0f)). 🤞Preview | Diff