Add isNaN and isInfinite operators#858
Merged
fdwr merged 6 commits intowebmachinelearning:mainfrom Aug 11, 2025
Merged
Conversation
Collaborator
Author
|
FYI @philloooo. |
huningxin
reviewed
Jun 5, 2025
huningxin
reviewed
Jun 6, 2025
github-actions bot
added a commit
that referenced
this pull request
Aug 11, 2025
SHA: 5d157b4 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #811. Since NaN and infinity are closely related concepts, I'm introducing both logical unary operators together for completeness.
partial interface MLGraphBuilder { ... + MLOperand isNaN(MLOperand a, optional MLOperatorOptions options = {}) + MLOperand isInfinite(MLOperand a, optional MLOperatorOptions options = {}) ... };Mappings to backend functions:
Is not-a-number:
Is infinite:
mil.ops.defs.iOS15.elementwise_binary.equal(.., Infinity)
Possible question answers:
isInfinite" rather than "isinf" like Python API's? This isn't Python, it's closer kin to Javascript'sisFinitefunction andInfiniteconstant, and general API naming guidelines favor whole words for readability.isInfiniteto emulate it.flattenandunsqueeze) in the Operator Emulation section.Here are some example emulations:
Preview | Diff