Skip to content

Comments

Add notes regarding label usage, provided by i18n review#841

Merged
anssiko merged 6 commits intowebmachinelearning:mainfrom
inexorabletash:i18n-label-notes
May 14, 2025
Merged

Add notes regarding label usage, provided by i18n review#841
anssiko merged 6 commits intowebmachinelearning:mainfrom
inexorabletash:i18n-label-notes

Conversation

@inexorabletash
Copy link
Contributor

@inexorabletash inexorabletash commented Apr 28, 2025

A suggested by @xfq, add additional details about operator labels, clarifying that they are not intended to be natural language strings. And include an advisement that use of developer-provided labels is subject to spoofing, and implementations should sanitize them.

Resolves #837


Preview | Diff

A suggested by @xfq, add additional details about operator labels,
clarifying that they are not intended to be natural language strings.
And include an advisement that use of developer-provided labels is
subject to spoofing, and implementations should sanitize them.
@inexorabletash
Copy link
Contributor Author

@xfq can you take a peek at the additions? I quoted your excellent suggested text directly.

Copy link
Member

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text in itself looks great to me. A suggestion on where to place this text:

Folks reading the Programming Model section may feel this section is too label heavy, so I suggest we place this text in https://www.w3.org/TR/webnn/#dom-mloperatoroptions-label instead.

Similarly, I'd propose to migrate the existing label related note to the same section.

(Per https://www.w3.org/TR/international-specs/#I18N_Considerations another option would be a dedicated Internationalization Considerations section but it seems inline in the body of the specification is preferred.)

@anssiko anssiko mentioned this pull request May 5, 2025
25 tasks
@inexorabletash
Copy link
Contributor Author

I suggest we place this text in https://www.w3.org/TR/webnn/#dom-mloperatoroptions-label instead.

Done in a3f8ab2

Co-authored-by: Anssi Kostiainen <[email protected]>
@anssiko anssiko merged commit 9527a73 into webmachinelearning:main May 14, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request May 14, 2025
SHA: 9527a73
Reason: push, by anssiko

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@inexorabletash inexorabletash deleted the i18n-label-notes branch May 14, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String metadata and localization for operator labels

3 participants