Editorial: Inline shape calculation algorithms only used once#814
Merged
huningxin merged 1 commit intowebmachinelearning:mainfrom Feb 15, 2025
inexorabletash:inline
Merged
Editorial: Inline shape calculation algorithms only used once#814huningxin merged 1 commit intowebmachinelearning:mainfrom inexorabletash:inline
huningxin merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:inline
Conversation
This is primarily to address an issue with "create pooling operation" where the input height and width are used before being calculated, but applies the same flattening across single use algorithms specific to shape calculation. The remaining helpers are either used multiple times by the same op algorithm (e.g. handling a single dimension) or shared across ops (e.g. reduction and argMin/argMax).
Contributor
Author
|
A follow-up to #806 (comment) - please take a look @huningxin and @fdwr ? |
fdwr
approved these changes
Feb 4, 2025
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍 Looks fine to me, mostly block moves (I wish GitHub CR diffs were a little clearer about simple line moves to speed up review). This will make the steps consistently inline AFAICS.
Contributor
Author
|
@huningxin can you take a look? |
github-actions bot
added a commit
that referenced
this pull request
Feb 15, 2025
SHA: a88bb0e Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily to address an issue with "create pooling operation" where the input height and width are used before being calculated, but applies the same flattening across single use algorithms specific to shape calculation. The remaining helpers are either used multiple times by the same op algorithm (e.g. handling a single dimension) or shared across ops (e.g. reduction and argMin/argMax).
Preview | Diff