Reject promises for in-progress operations on an MLTensor if it is destroyed#799
Merged
fdwr merged 4 commits intowebmachinelearning:mainfrom Mar 19, 2025
Merged
Conversation
inexorabletash
approved these changes
Dec 13, 2024
Contributor
inexorabletash
left a comment
inexorabletash
left a comment
There was a problem hiding this comment.
LGTM with one nitpick
Collaborator
|
FYI @bbernhar and @RafaelCintron. |
Contributor
Author
|
Just resolved merge conflicts. Should be ready to go 👍 |
RafaelCintron
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles the following case:
The current spec does not reject
promisein this example. This PR updates the spec to match the Chromium implementation and what I assume to be the desired behavior (please speak up otherwise!)Note that Chromium implements a similar pattern in other cases where the
MLContextmay be destroyed (either intentionally or unexpectedly), but specification of that work should follow #744Preview | Diff