Editorial: Various style and wording tweaks#797
Merged
fdwr merged 13 commits intowebmachinelearning:mainfrom Jan 31, 2025
inexorabletash:misc-phrasing-tweaks
Merged
Editorial: Various style and wording tweaks#797fdwr merged 13 commits intowebmachinelearning:mainfrom inexorabletash:misc-phrasing-tweaks
fdwr merged 13 commits intowebmachinelearning:mainfrom
inexorabletash:misc-phrasing-tweaks
Conversation
Instead of "*foo[bar]*" make it "*foo*[*bar*]" just so that turning "foo" and "bar" into links is a more atomic operation. Purely stylistic. Part of #783
huningxin
reviewed
Dec 9, 2024
| : <dfn>bias</dfn> | ||
| :: | ||
| The 2-D input bias tensor of shape *[numDirections, 3 * hiddenSize]*. The ordering of the bias vectors in the second dimension of the tensor shape is specified according to the {{MLGruOptions/layout}} argument. | ||
| The 2-D input bias tensor of shape *[numDirections, 3 * hiddenSize]*. The ordering of the bias vectors in the second dimension of the tensor shape is specified according to {{MLGruOptions/layout}}. |
Contributor
There was a problem hiding this comment.
Should we format each numDirections and hiddenSize separately? Like [*numDirections*, 3 * *hiddenSize*], same for other occurrences.
Contributor
Author
There was a problem hiding this comment.
Right now the coding conventions say When concisely defining a tensor's layout, use the syntax *[ ... ]* which we'd need to revise. More feedback wanted!
huningxin
reviewed
Dec 9, 2024
index.bs
Outdated
|
|
||
| <div class="note"> | ||
| A *depthwise* conv2d operation is a variant of grouped convolution, used in models like the MobileNet, where the *options.groups* = inputChannels = outputChannels and the shape of filter tensor is *[options.groups, 1, height, width]* | ||
| A *depthwise* conv2d operation is a variant of grouped convolution, used in models like the MobileNet, where the *options*.{{MLConv2dOptions/groups}} = inputChannels = outputChannels and the shape of filter tensor is *[options.groups, 1, height, width]* |
Contributor
There was a problem hiding this comment.
Should inputChannels and outputChannels be formatted? In *[options.groups, 1, height, width]*, should we use [*options*.{{MLConv2dOptions/groups}}, 1, *height*, *width*]?
I found the prose of MLConv2dOptions.inputLayout and MLConv2dOptions.filterLayout also refer to variables including inputChannels and outputChannels etc.,. Should we also format them separately?
Contributor
Author
There was a problem hiding this comment.
Formatted *inputChannels* and *outputChannels* in that instance (in f714fc1) . As noted above, need to decide more generally on how to format shapes.
fdwr
approved these changes
Jan 30, 2025
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
One confirmation, else LGTM. TY Josh.
Contributor
Author
|
I think this is good to merge now, @fdwr ? |
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2025
SHA: 74b5ae5 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zolkis
pushed a commit
to zolkis/webnn
that referenced
this pull request
Feb 6, 2025
* Editorial: Avoid the wordier "the XYZ argument"; just say "XYZ". Part of webmachinelearning#783 * Editorial: Eschew vars outside of algorithms Part of webmachinelearning#783 * Editorial: Make dict member linking more consistent Part of webmachinelearning#783 * Editorial: Format explanatory subscripts to emphasize variables Instead of "*foo[bar]*" make it "*foo*[*bar*]" just so that turning "foo" and "bar" into links is a more atomic operation. Purely stylistic. Part of webmachinelearning#783 * Editorial: Drop "options.", rely on linking to provide context Part of webmachinelearning#783 * Editorial: Linkify all argument/option references outside algorithms Part of webmachinelearning#783 * Incorporate initial feedback * Incorporate more feedback - style/link a few more things * Remove extraneous * in example
zolkis
pushed a commit
to zolkis/webnn
that referenced
this pull request
Feb 6, 2025
* Editorial: Avoid the wordier "the XYZ argument"; just say "XYZ". Part of webmachinelearning#783 * Editorial: Eschew vars outside of algorithms Part of webmachinelearning#783 * Editorial: Make dict member linking more consistent Part of webmachinelearning#783 * Editorial: Format explanatory subscripts to emphasize variables Instead of "*foo[bar]*" make it "*foo*[*bar*]" just so that turning "foo" and "bar" into links is a more atomic operation. Purely stylistic. Part of webmachinelearning#783 * Editorial: Drop "options.", rely on linking to provide context Part of webmachinelearning#783 * Editorial: Linkify all argument/option references outside algorithms Part of webmachinelearning#783 * Incorporate initial feedback * Incorporate more feedback - style/link a few more things * Remove extraneous * in example
zolkis
pushed a commit
to zolkis/webnn
that referenced
this pull request
Feb 6, 2025
* Editorial: Avoid the wordier "the XYZ argument"; just say "XYZ". Part of webmachinelearning#783 * Editorial: Eschew vars outside of algorithms Part of webmachinelearning#783 * Editorial: Make dict member linking more consistent Part of webmachinelearning#783 * Editorial: Format explanatory subscripts to emphasize variables Instead of "*foo[bar]*" make it "*foo*[*bar*]" just so that turning "foo" and "bar" into links is a more atomic operation. Purely stylistic. Part of webmachinelearning#783 * Editorial: Drop "options.", rely on linking to provide context Part of webmachinelearning#783 * Editorial: Linkify all argument/option references outside algorithms Part of webmachinelearning#783 * Incorporate initial feedback * Incorporate more feedback - style/link a few more things * Remove extraneous * in example
github-actions bot
added a commit
to zolkis/webnn
that referenced
this pull request
Feb 12, 2025
SHA: 74b5ae5 Reason: push, by zolkis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the changes outlined in #783
To make reviewing easier I've left it as a chain of commits, each one tackling just one stylistic change.
Resolves #783
Preview | Diff