Merged
Conversation
This is to address feedback from the TAG review: w3ctag/design-reviews#933
reillyeon
approved these changes
Oct 11, 2024
Member
Author
|
PTAL @RafaelCintron, I appreciate a review from you because this in part builds upon a discussion you had with the TAG. |
fdwr
approved these changes
Oct 23, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Approved with grammar suggestions. @RafaelCintron may have thoughts too.
Co-authored-by: Dwayne Robinson <[email protected]>
Member
Author
|
@fdwr thank you for the review and grammar suggestions. |
Member
Author
|
I'll merge this PR now to focus our open PR queue. I'll also inform the TAG that we've addressed their feedback. |
github-actions bot
added a commit
that referenced
this pull request
Oct 24, 2024
SHA: 2cc59c5 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first stab to port comments from @RafaelCintron @reillyeon in the TAG issue w3ctag/design-reviews#933 to the specification to address feedback from the TAG. Please suggest changes to make sure key points are captured.
Preview | Diff