Skip to content

Comments

Make MLOperandDescriptor.shape required#764

Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom
a-sully:require-shape
Sep 25, 2024
Merged

Make MLOperandDescriptor.shape required#764
fdwr merged 1 commit intowebmachinelearning:mainfrom
a-sully:require-shape

Conversation

@a-sully
Copy link
Contributor

@a-sully a-sully commented Sep 24, 2024

Fixes #758


Preview | Diff

Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 81a355a into webmachinelearning:main Sep 25, 2024
github-actions bot added a commit that referenced this pull request Sep 25, 2024
SHA: 81a355a
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@a-sully a-sully deleted the require-shape branch September 26, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make MLOperandDescriptor.shape a required dictionary member

3 participants