Bugfix: Rename member output to outputs of MLLstmCellSupportLimits#757
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Sep 5, 2024
Merged
Conversation
Contributor
Author
|
@shiyi9801 @philloooo PTAL, thanks! |
`MLLstmCellSupportLimits.outputs` reflects that lstmCell returns a sequence of operands. Fix webmachinelearning#755 (comment)
huningxin
force-pushed
the
fix_lstm_cell_support_limits
branch
from
4156995 to
9e2dfc6
Compare
Contributor
|
LGTM! |
Collaborator
|
Although Phillis hasn't reviewed this, she did thumbs-up your comment on the matter, and you got 2 other reviews. So I will merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLLstmCellSupportLimits.outputsreflects that lstmCell returns a sequence of operands.Fix #755 (comment)
Preview | Diff