Clarify reduction with empty axes and scalar input#741
Merged
fdwr merged 12 commits intowebmachinelearning:mainfrom Jul 30, 2024
inexorabletash:reduction-reword
Merged
Clarify reduction with empty axes and scalar input#741fdwr merged 12 commits intowebmachinelearning:mainfrom inexorabletash:reduction-reword
fdwr merged 12 commits intowebmachinelearning:mainfrom
inexorabletash:reduction-reword
Conversation
Improve the description of the reduction ops: - Give in-line definition for L1/L2. - Make "input values" slightly clearer. - Explicitly note that if the input is a scalar, so is the output. - State how the reduction function is applied for empty axes. - Standardize on "reduction operation" not "reduce operation". Fixes #740
Contributor
Author
|
@philloooo - does this make the behavior clearer? |
The "reduction types" list was styled as a non-normative note. The element-wise ops (add, equal, abs, etc.) don't do this. Be consistent here.
inexorabletash
changed the title
huningxin
reviewed
Jul 25, 2024
fdwr
reviewed
Jul 30, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Clarification is goodness 👍. Some wording thoughts.
Co-authored-by: Dwayne Robinson <[email protected]>
Co-authored-by: Dwayne Robinson <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jul 30, 2024
SHA: 4697a0d Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the description of the reduction ops:
Fixes #740
Preview | Diff