Add helper for creating MLOperandDescriptor to simplify steps#737
Merged
fdwr merged 7 commits intowebmachinelearning:mainfrom Jul 25, 2024
inexorabletash:op-desc-helper
Merged
Add helper for creating MLOperandDescriptor to simplify steps#737fdwr merged 7 commits intowebmachinelearning:mainfrom inexorabletash:op-desc-helper
fdwr merged 7 commits intowebmachinelearning:mainfrom
inexorabletash:op-desc-helper
Conversation
The only non-trivial bits are a few cases where in the previous steps the shape was calculated after the MLOperandDescriptor was created, but this would not be an observable change to script.
Contributor
Author
|
Deleting lines is good! This should be pretty straightforward. @huningxin & @fdwr can you please review? |
Contributor
Author
|
This would also simplify #676 significantly. |
fdwr
reviewed
Jul 25, 2024
fdwr
approved these changes
Jul 25, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
This should cut down on the tedium some. Looks good with one addition.
Co-authored-by: Ningxin Hu <[email protected]>
Also, retain usage of "bidirectionally broadcastable"
fdwr
approved these changes
Jul 25, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍 TY. Fixing a small typo and merging.
github-actions bot
added a commit
that referenced
this pull request
Jul 25, 2024
SHA: bd5da6b Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only non-trivial bits are a few cases where in the previous steps the shape was calculated after the MLOperandDescriptor was created, but this would not be an observable change to script.
Preview | Diff