Editorial: Don't reference IDL boolean for values in tensors#735
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Jul 23, 2024
inexorabletash:no-idl-bool
Merged
Editorial: Don't reference IDL boolean for values in tensors#735fdwr merged 1 commit intowebmachinelearning:mainfrom inexorabletash:no-idl-bool
fdwr merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:no-idl-bool
Conversation
The spec should only reference IDL types in prose when dealing with binding, e.g. in unions, and maybe internal slots. When discussing values in tensors, just be explicit and don't try to link to a definition that doesn't really apply.
Contributor
Author
|
Another simple one - @fdwr can you review/merge? |
Collaborator
|
@huningxin - this one is simple enough that I'll just merge it now. Please comment afterward if anything was dubious. |
github-actions bot
added a commit
that referenced
this pull request
Jul 23, 2024
SHA: 4b90605 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec should only reference IDL types in prose when dealing with binding, e.g. in unions, and maybe internal slots. When discussing values in tensors, just be explicit and don't try to link to a definition that doesn't really apply.
Preview | Diff