Avoid "sequence" in prose, linkify use in types#729
Merged
fdwr merged 3 commits intowebmachinelearning:mainfrom Jul 18, 2024
inexorabletash:linkify-sequence
Merged
Avoid "sequence" in prose, linkify use in types#729fdwr merged 3 commits intowebmachinelearning:mainfrom inexorabletash:linkify-sequence
fdwr merged 3 commits intowebmachinelearning:mainfrom
inexorabletash:linkify-sequence
Conversation
Per the spec processing model, algorithms don't usually deal with a sequence<T> type; the JS value has been converted to an Infra list. So try to avoid using that term in prose, especially as it is confusing for recurrent operators which have temporal sequences as well. But do call out an exception: unpacking unions. When used in an IDL type description, though, do linkify it. Fix a few other grammar/link glitches, too.
fdwr
approved these changes
Jul 18, 2024
Co-authored-by: Dwayne Robinson <[email protected]>
Contributor
Author
|
Merge when ready! |
github-actions bot
added a commit
that referenced
this pull request
Jul 19, 2024
SHA: c4de3ef Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the spec processing model, algorithms don't usually deal with a sequence type; the JS value has been converted to an Infra list. So try to avoid using that term in prose, especially as it is confusing for recurrent operators which have temporal sequences as well. But do call out an exception: unpacking unions.
When used in an IDL type description, though, do linkify it.
Fix a few other grammar/link glitches, too.
Preview | Diff