Lint: Improve logic for validating algorithm steps.#727
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Jul 17, 2024
inexorabletash:lint-step-endings
Merged
Lint: Improve logic for validating algorithm steps.#727fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:lint-step-endings
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:lint-step-endings
Conversation
Contributor
Author
|
Oops - I let some lint failures sneak in f5fb055 by following WebIDL's source style rather than our source style. But the lint logic should be improved anyway, so improve that. @huningxin & @fdwr - could you please review and merge if it looks okay? I'll work on getting the lint tool hooked up as a github action. |
Previously, the test ensuring that algorithm steps end in '.' or ':' looked at the Bikeshed source. This didn't handle word wrapping. While we prefer not to word wrap, that shouldn't cause this test to fail. Make the test analyse the DOM instead.
github-actions bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: ac83a20 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the test ensuring that algorithm steps end in '.' or ':' looked at the Bikeshed source. This didn't handle word wrapping. While we prefer not to word wrap, that shouldn't cause this test to fail.
Make the test analyse the DOM instead.
Also, fix some unrelated Bikeshed/lint failures introduced in f08f9f7
Preview | Diff