Clarify the cast() op behavior between different data types#726
Merged
fdwr merged 4 commits intowebmachinelearning:mainfrom Jul 17, 2024
inexorabletash:cast-op-behavior
Merged
Clarify the cast() op behavior between different data types#726fdwr merged 4 commits intowebmachinelearning:mainfrom inexorabletash:cast-op-behavior
fdwr merged 4 commits intowebmachinelearning:mainfrom
inexorabletash:cast-op-behavior
Conversation
Inspired by the ONNX documentation[1], outline what inference-time casts are well-defined and which are implementation-defined for out-of-range values. Fixes #489 1: https://onnx.ai/onnx/operators/onnx__Cast.html
Contributor
Author
|
@fdwr & @huningxin - could you please review? Hopefully I didn't go too far with the table styling. |
fdwr
reviewed
Jul 17, 2024
fdwr
approved these changes
Jul 17, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍 Thanks JB for adding clarity.
fdwr
approved these changes
Jul 17, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: 19762ed Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the ONNX documentation[1], outline what inference-time casts are well-defined and which are implementation-defined for out-of-range values.
Fixes #489
1: https://onnx.ai/onnx/operators/onnx__Cast.html
Preview | Diff