Rename where()'s parameters "input" and "other" to "trueValue" and "falseValue"#719
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Jul 11, 2024
Merged
Conversation
Contributor
|
@shiyi9801 can you follow the instructions at https://labs.w3.org/repo-manager/pr/id/webmachinelearning/webnn/719 to link a W3C account to your github account? That will resolve this and any future IPR issues. |
Contributor
Author
Done, thanks for the instruction! |
Collaborator
|
Yes please. Thank you. Clarity++. |
fdwr
approved these changes
Jul 11, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2024
SHA: fe96a78 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR was raised by @philloooo in CL-5679616 review)
@wacky6 suggested using
trueValuefalseValueto indicate the values are picked based on true/false ofconditionin CL-5039655 review. Also the current Chromium implementation uses namestrueValueandfalseValue.Preview | Diff