Remove unnecessary subsections, make order consistent#711
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Jun 26, 2024
inexorabletash:tidy-subsections
Merged
Remove unnecessary subsections, make order consistent#711fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:tidy-subsections
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:tidy-subsections
Conversation
The MLActivation-vending overloads for clamp() and softmax() were removed, so for consistency these methods should no longer have an `<h4>`. Also, make the order match the other non-overloaded methods: * Description * IDL * Options (if provided) * Arguments * Returns * Method algorithm * Emulation (if provided) (The methods with overloads put the emulation before the method algorithms for some reason.)
For methods with MLActivation-vending overloads, the emulation / decomposition was given before the steps for either the MLOperand or MLActivation steps, which is misleadng - the MLActivation is fused and can't be emulated with the current API. Make the order consistent, and put the emulation after the emulated steps.
Contributor
Author
|
Another trivial cleanup - mostly just moving blocks of text around. PTAL? |
fdwr
approved these changes
Jun 26, 2024
github-actions bot
added a commit
that referenced
this pull request
Jun 26, 2024
SHA: f7ceef9 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With two MLActivation-vending overloads removed, two subsection headers could be removed.
But that pointed out where ordering for the "emulation" section in overloaded methods was inconsistent. So tidy that up too.
Preview | Diff