Bug fix: Correct a handful of typos/JS errors in decompositions#699
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Jun 5, 2024
inexorabletash:emu-fixes
Merged
Bug fix: Correct a handful of typos/JS errors in decompositions#699fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:emu-fixes
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:emu-fixes
Conversation
Typos of "builder", incorrect arrow function syntax. No normative changes.
Contributor
Author
|
@zolkis and @huningxin - can you take a look? Note that this just fixes some tiny and obvious errors. I have some follow up work that ensures that the decompositions don't reference undefined variables, but wanted to keep that separate. |
Contributor
|
@inexorabletash , could you please resolve the merge conflicts? So, I can merge it, thanks! |
Contributor
Author
|
Conflicts resolved (hopefully) - going to bed now, I'll fix in the morning if you notice any glitches. |
Contributor
Author
|
@huningxin this should be good to merge now |
Contributor
Author
|
Merge when you're ready! |
github-actions bot
added a commit
that referenced
this pull request
Jun 5, 2024
SHA: f133ff0 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typos of "builder", incorrect arrow function syntax.
No normative changes.
Preview | Diff