Add missing validation for pad(), slice(), and split()#690
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom May 23, 2024
inexorabletash:pad-slice-split-validation
Merged
Add missing validation for pad(), slice(), and split()#690fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:pad-slice-split-validation
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:pad-slice-split-validation
Conversation
Noticed during a review of the Chromium prototype. These are all pretty obvious except for slice() where there is subtlety for 0-size dimensions. I added an issue linking to #391 since the steps will need to be revised depending on how that issue is resolved.
Contributor
Author
|
@huningxin - can you take a first look? Thanks! |
huningxin
reviewed
May 21, 2024
Contributor
|
@fdwr is OOO this week and might not have bandwidth to review this PR. I think it's straightforward and could be merged. @inexorabletash , WDYT? |
fdwr
reviewed
May 23, 2024
fdwr
approved these changes
May 23, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍 Thanks as always Joshua.
github-actions bot
added a commit
that referenced
this pull request
May 23, 2024
SHA: 960ae89 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed during a review of the Chromium prototype. These are all pretty obvious except for slice() where there is subtlety for 0-size dimensions. I added an issue linking to #391 since the steps will need to be revised depending on how that issue is resolved.
Preview | Diff