Add missing definitions of inputShape to conv2d algorithms#680
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom May 6, 2024
inexorabletash:fix-inputshape-vars
Merged
Add missing definitions of inputShape to conv2d algorithms#680fdwr merged 1 commit intowebmachinelearning:mainfrom inexorabletash:fix-inputshape-vars
fdwr merged 1 commit intowebmachinelearning:mainfrom
inexorabletash:fix-inputshape-vars
Conversation
The algorithms for both conv2d() and convTranspose2d() used an `inputShape` local variable, but never defined it. Oops! The meaning was obvious, but we do need to define and initialize it to keep tooling happy.
Contributor
Author
|
Easy one. Please take a look and merge if it's okay, @fdwr and @huningxin ? I'm marking this "editorial" because it doesn't change the semantics of the API even though it touches an algorithm, and the meaning was obvious. FYI this glitch was revealed by my "work in progress" lint tool, after I fixed an HTML parsing glitch while investigating #679 |
Contributor
Author
|
Note: failed checks due to the issue fixed in #679 |
fdwr
approved these changes
May 6, 2024
Collaborator
There was a problem hiding this comment.
👍 TY.
@huningxin : This one looks straight forward enough that I'll just merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithms for both conv2d() and convTranspose2d() used an
inputShapelocal variable, but never defined it. Oops! The meaning was obvious, but we do need to define and initialize it to keep tooling happy.Preview | Diff