Use consistent phrasing for operator creation#674
Merged
huningxin merged 4 commits intowebmachinelearning:mainfrom May 10, 2024
inexorabletash:op-name-consistency
Merged
Use consistent phrasing for operator creation#674huningxin merged 4 commits intowebmachinelearning:mainfrom inexorabletash:op-name-consistency
huningxin merged 4 commits intowebmachinelearning:mainfrom
inexorabletash:op-name-consistency
Conversation
Places that create ops use an inconsistent mixed of simple phrases, camelCase, Title Case, ACRONYMS, and "quoted strings". The most common was camelCase, but the wording can be weird, and the bulk-defined binary/unary/logical/pooling/reduction ops and activations use a "quotedCamelCase", so I went with that. See #591 (comment) for the most commentary. Resolves #572
Contributor
Author
|
Super minor; mostly putting this up so we can close #572 and stop talking about it at the telecons. 😉 |
Contributor
Author
|
@zolkis can you take a look? Low priority. |
Contributor
Author
|
Thanks @zolkis ! @huningxin & @fdwr - could you please review and merge if it looks good? Thanks! |
fdwr
reviewed
May 9, 2024
fdwr
approved these changes
May 9, 2024
github-actions bot
added a commit
that referenced
this pull request
May 10, 2024
SHA: 587af73 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places that create ops use an inconsistent mixed of simple phrases, camelCase, Title Case, ACRONYMS, and "quoted strings". The most common was camelCase, but the wording can be weird, and the bulk-defined binary/unary/logical/pooling/reduction ops and activations use a "quotedCamelCase", so I went with that.
See #591 (comment) for the most commentary.
Resolves #572
Preview | Diff