Remove MLActivation parameters used for op fusion#664
Merged
huningxin merged 6 commits intowebmachinelearning:mainfrom May 5, 2024
Merged
Remove MLActivation parameters used for op fusion#664huningxin merged 6 commits intowebmachinelearning:mainfrom
huningxin merged 6 commits intowebmachinelearning:mainfrom
Conversation
inexorabletash
suggested changes
May 1, 2024
inexorabletash
approved these changes
May 1, 2024
Collaborator
|
(note Ningxin is on holiday the next few days) |
fdwr
approved these changes
May 1, 2024
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
Looks good to me Mr. Sully. Thanks for opening the issue and updating the spec.
We should get a collateral impact assessment from @Honry and @huningxin, as I see them used in a few places, but it would be mostly code removal and simplification in the WebNN EP, as the Chromium implementation fuses them anyway regardless of the caller.
huningxin
reviewed
May 3, 2024
huningxin
reviewed
May 3, 2024
Co-authored-by: Ningxin Hu <[email protected]>
Contributor
Author
|
Thanks for the suggestions! They've since been incorporated :) |
fdwr
approved these changes
May 4, 2024
github-actions bot
added a commit
that referenced
this pull request
May 5, 2024
SHA: 266eae1 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 5, 2024
Remove the ability to specify op fusions from the web platform layer. Ops can still be fused, but this is now the responsibility of the respective WebNN backend Corresponds to the spec PR merged here: webmachinelearning/webnn#664 Bug: 341518634 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Change-Id: I8a4f2ab708e34087eeb10421596243b17bc8d7e2
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 5, 2024
Remove the ability to specify op fusions from the web platform layer. Ops can still be fused, but this is now the responsibility of the respective WebNN backend Corresponds to the spec PR merged here: webmachinelearning/webnn#664 Bug: 341518634 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Change-Id: I8a4f2ab708e34087eeb10421596243b17bc8d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494397 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1310724}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 5, 2024
Remove the ability to specify op fusions from the web platform layer. Ops can still be fused, but this is now the responsibility of the respective WebNN backend Corresponds to the spec PR merged here: webmachinelearning/webnn#664 Bug: 341518634 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Change-Id: I8a4f2ab708e34087eeb10421596243b17bc8d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494397 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1310724}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 12, 2024
…vations for op fusion, a=testonly Automatic update from web-platform-tests webnn: Remove support for passing MLActivations for op fusion Remove the ability to specify op fusions from the web platform layer. Ops can still be fused, but this is now the responsibility of the respective WebNN backend Corresponds to the spec PR merged here: webmachinelearning/webnn#664 Bug: 341518634 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Change-Id: I8a4f2ab708e34087eeb10421596243b17bc8d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494397 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1310724} -- wpt-commits: e3235d9662ee81945c7ff6242fc8fe0628c509c8 wpt-pr: 45937
4 tasks
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
…vations for op fusion, a=testonly Automatic update from web-platform-tests webnn: Remove support for passing MLActivations for op fusion Remove the ability to specify op fusions from the web platform layer. Ops can still be fused, but this is now the responsibility of the respective WebNN backend Corresponds to the spec PR merged here: webmachinelearning/webnn#664 Bug: 341518634 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Change-Id: I8a4f2ab708e34087eeb10421596243b17bc8d7e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494397 Reviewed-by: ningxin hu <[email protected]> Reviewed-by: Alex Gough <[email protected]> Commit-Queue: Austin Sullivan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1310724} -- wpt-commits: e3235d9662ee81945c7ff6242fc8fe0628c509c8 wpt-pr: 45937
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Preview | Diff